Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Gerald Schaefer <gerald.schaefer@de.ibm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>,
	linux-crypto@vger.kernel.org,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Ingo Tuchscherer <ingo.tuchscherer@linux.vnet.ibm.com>,
	Harald Freudenberger <freude@linux.vnet.ibm.com>
Subject: Re: [PATCH] crypto: s390 - Fix aes-xts parameter corruption
Date: Fri, 22 Nov 2013 14:57:56 +0100	[thread overview]
Message-ID: <20131122145756.387d7638@vbox-ubuntu> (raw)
In-Reply-To: <1384877567-23593-1-git-send-email-gerald.schaefer@de.ibm.com>

On Tue, 19 Nov 2013 17:12:47 +0100
Gerald Schaefer <gerald.schaefer@de.ibm.com> wrote:

> Some s390 crypto algorithms incorrectly use the crypto_tfm structure
> to store private data. As the tfm can be shared among multiple
> threads, this can result in data corruption.
> 
> This patch fixes aes-xts by moving the xts and pcc parameter blocks
> from the tfm onto the stack (48 + 96 bytes).
> 
> Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
> ---
>  arch/s390/crypto/aes_s390.c | 31 +++++++++++++++++--------------
>  1 file changed, 17 insertions(+), 14 deletions(-)

Herbert, could you please add Cc: stable@vger.kernel.org to this?

  reply	other threads:[~2013-11-22 13:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19 16:12 [PATCH] crypto: s390 - Fix aes-xts parameter corruption Gerald Schaefer
2013-11-22 13:57 ` Gerald Schaefer [this message]
2013-11-28 14:26   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131122145756.387d7638@vbox-ubuntu \
    --to=gerald.schaefer@de.ibm.com \
    --cc=freude@linux.vnet.ibm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=ingo.tuchscherer@linux.vnet.ibm.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox