Re: [PATCH RFC] CRYPTO: Fix more AES build errors:

[Russell King - ARM Linux <linux@arm.linux.org.uk>]

On Sun, Jan 05, 2014 at 08:51:05PM +0800, Herbert Xu wrote:
> On Thu, Jan 02, 2014 at 07:16:46PM +0100, Ard Biesheuvel wrote:
> > On 2 January 2014 18:17, Russell King <rmk+kernel@arm.linux.org.uk> wrote:
> > > Building a multi-arch kernel results in:
> > >
> > > arch/arm/crypto/built-in.o: In function `aesbs_xts_decrypt':
> > > sha1_glue.c:(.text+0x15c8): undefined reference to `bsaes_xts_decrypt'
> > > arch/arm/crypto/built-in.o: In function `aesbs_xts_encrypt':
> > > sha1_glue.c:(.text+0x1664): undefined reference to `bsaes_xts_encrypt'
> > > arch/arm/crypto/built-in.o: In function `aesbs_ctr_encrypt':
> > > sha1_glue.c:(.text+0x184c): undefined reference to `bsaes_ctr32_encrypt_blocks'
> > > arch/arm/crypto/built-in.o: In function `aesbs_cbc_decrypt':
> > > sha1_glue.c:(.text+0x19b4): undefined reference to `bsaes_cbc_encrypt'
> > >
> > 
> > Interestingly, when I try to reproduce this, the reference is
> > (correctly) reported to reside in aesbs-glue.c and not sha1_glue.c
> > 
> > > This code is already runtime-conditional on NEON being supported, so
> > > there's no point compiling it out depending on the minimum build
> > > architecture.
> > >
> > 
> > Agreed. It is a leftover from the way this code was embedded into
> > OpenSSL originally.
> > 
> > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > > ---
> > > This is more a request for acks since I'd like to keep it/push it through
> > > my tree to reduce the autobuilder failures.
> > >
> > >  arch/arm/crypto/bsaes-armv7.pl |    2 +-
> > 
> > The .S_shipped file produced by this script should be updated at the same time.
> > 
> > Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> Patch applied to the crypto tree.  Thanks a lot!

Since when do patches with "RFC" in the subject line get applied to other
people's trees?

I also had this in the original message:

"This is more a request for acks since I'd like to keep it/push it through
 my tree to reduce the autobuilder failures."

And I've just sent Linus the pull request which contains this... though
I now realise I didn't add Ard's ack.  Oh well, too late. :(

-- 
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".