* [PATCH] crypto: omap-des - use devm_ioremap_resource()
@ 2014-04-03 0:18 Jingoo Han
2014-04-08 4:54 ` [PATCH V2] " Jingoo Han
0 siblings, 1 reply; 6+ messages in thread
From: Jingoo Han @ 2014-04-03 0:18 UTC (permalink / raw)
To: 'Herbert Xu'
Cc: 'David Miller', linux-crypto, 'Jingoo Han',
'Joel Fernandes'
Use devm_ioremap_resource() because devm_request_and_ioremap() is
obsoleted by devm_ioremap_resource().
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/crypto/omap-des.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
index ec5f131..f5bafd0 100644
--- a/drivers/crypto/omap-des.c
+++ b/drivers/crypto/omap-des.c
@@ -1074,10 +1074,10 @@ static int omap_des_probe(struct platform_device *pdev)
if (err)
goto err_res;
- dd->io_base = devm_request_and_ioremap(dev, res);
- if (!dd->io_base) {
+ dd->io_base = devm_ioremap_resource(dev, res);
+ if (IS_ERR(dd->io_base)) {
dev_err(dev, "can't ioremap\n");
- err = -ENOMEM;
+ err = PTR_ERR(dd->io_base);
goto err_res;
}
dd->phys_base = res->start;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V2] crypto: omap-des - use devm_ioremap_resource()
2014-04-03 0:18 [PATCH] crypto: omap-des - use devm_ioremap_resource() Jingoo Han
@ 2014-04-08 4:54 ` Jingoo Han
2014-04-09 15:35 ` Joel Fernandes
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jingoo Han @ 2014-04-08 4:54 UTC (permalink / raw)
To: 'Herbert Xu'
Cc: 'David Miller', linux-crypto, 'Joel Fernandes',
'Jingoo Han'
Use devm_ioremap_resource() because devm_request_and_ioremap() is
obsoleted by devm_ioremap_resource().
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Changes since v1:
- remove unnecessary error message, because devm_ioremap_resource()
already prints one in all failure cases.
drivers/crypto/omap-des.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
index ec5f131..4a13624 100644
--- a/drivers/crypto/omap-des.c
+++ b/drivers/crypto/omap-des.c
@@ -1074,10 +1074,9 @@ static int omap_des_probe(struct platform_device *pdev)
if (err)
goto err_res;
- dd->io_base = devm_request_and_ioremap(dev, res);
- if (!dd->io_base) {
- dev_err(dev, "can't ioremap\n");
- err = -ENOMEM;
+ dd->io_base = devm_ioremap_resource(dev, res);
+ if (IS_ERR(dd->io_base)) {
+ err = PTR_ERR(dd->io_base);
goto err_res;
}
dd->phys_base = res->start;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V2] crypto: omap-des - use devm_ioremap_resource()
2014-04-08 4:54 ` [PATCH V2] " Jingoo Han
@ 2014-04-09 15:35 ` Joel Fernandes
2014-04-09 17:36 ` Marek Vasut
2014-04-10 15:55 ` Joel Fernandes
2 siblings, 0 replies; 6+ messages in thread
From: Joel Fernandes @ 2014-04-09 15:35 UTC (permalink / raw)
To: Jingoo Han, 'Herbert Xu'; +Cc: 'David Miller', linux-crypto
On 04/07/2014 11:54 PM, Jingoo Han wrote:
> Use devm_ioremap_resource() because devm_request_and_ioremap() is
> obsoleted by devm_ioremap_resource().
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> Changes since v1:
> - remove unnecessary error message, because devm_ioremap_resource()
> already prints one in all failure cases.
>
> drivers/crypto/omap-des.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
> index ec5f131..4a13624 100644
> --- a/drivers/crypto/omap-des.c
> +++ b/drivers/crypto/omap-des.c
> @@ -1074,10 +1074,9 @@ static int omap_des_probe(struct platform_device *pdev)
> if (err)
> goto err_res;
>
> - dd->io_base = devm_request_and_ioremap(dev, res);
> - if (!dd->io_base) {
> - dev_err(dev, "can't ioremap\n");
> - err = -ENOMEM;
> + dd->io_base = devm_ioremap_resource(dev, res);
> + if (IS_ERR(dd->io_base)) {
> + err = PTR_ERR(dd->io_base);
> goto err_res;
> }
> dd->phys_base = res->start;
>
Acked-by: Joel Fernandes <joelf@ti.com>
Thanks,
-Joel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH V2] crypto: omap-des - use devm_ioremap_resource()
2014-04-08 4:54 ` [PATCH V2] " Jingoo Han
2014-04-09 15:35 ` Joel Fernandes
@ 2014-04-09 17:36 ` Marek Vasut
2014-04-10 15:55 ` Joel Fernandes
2 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2014-04-09 17:36 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Herbert Xu', 'David Miller', linux-crypto,
'Joel Fernandes'
On Tuesday, April 08, 2014 at 06:54:22 AM, Jingoo Han wrote:
> Use devm_ioremap_resource() because devm_request_and_ioremap() is
> obsoleted by devm_ioremap_resource().
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] crypto: omap-des - use devm_ioremap_resource()
2014-04-08 4:54 ` [PATCH V2] " Jingoo Han
2014-04-09 15:35 ` Joel Fernandes
2014-04-09 17:36 ` Marek Vasut
@ 2014-04-10 15:55 ` Joel Fernandes
2014-04-16 13:48 ` Herbert Xu
2 siblings, 1 reply; 6+ messages in thread
From: Joel Fernandes @ 2014-04-10 15:55 UTC (permalink / raw)
To: Jingoo Han, 'Herbert Xu'; +Cc: 'David Miller', linux-crypto
On 04/07/2014 11:54 PM, Jingoo Han wrote:
> Use devm_ioremap_resource() because devm_request_and_ioremap() is
> obsoleted by devm_ioremap_resource().
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Joel Fernandes <joelf@ti.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-04-16 13:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-03 0:18 [PATCH] crypto: omap-des - use devm_ioremap_resource() Jingoo Han
2014-04-08 4:54 ` [PATCH V2] " Jingoo Han
2014-04-09 15:35 ` Joel Fernandes
2014-04-09 17:36 ` Marek Vasut
2014-04-10 15:55 ` Joel Fernandes
2014-04-16 13:48 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).