* [PATCH] staging: crypto: skein: depend upon CRYPTO
[not found] <20140425151554.GB31117@localhost>
@ 2014-04-25 16:45 ` Jason Cooper
2014-04-28 21:38 ` Marek Vasut
0 siblings, 1 reply; 2+ messages in thread
From: Jason Cooper @ 2014-04-25 16:45 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jason Cooper, Fengguang Wu, kbuild-all, linux-crypto,
linux-kernel
Fengguang's randconfig kernel build tester discovered the following
warnings:
warning: (CRYPTO_THREEFISH) selects CRYPTO_ALGAPI which has unmet direct dependencies (CRYPTO)
warning: (DM_VERITY && CRYPTO_SKEIN) selects CRYPTO_HASH which has unmet direct dependencies (CRYPTO)
Fix this in the Kconfig by depending on CRYPTO.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
---
drivers/staging/skein/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/skein/Kconfig b/drivers/staging/skein/Kconfig
index 8f5a72a90ced..b9172bfcdc1b 100644
--- a/drivers/staging/skein/Kconfig
+++ b/drivers/staging/skein/Kconfig
@@ -1,6 +1,6 @@
config CRYPTO_SKEIN
bool "Skein digest algorithm"
- depends on (X86 || UML_X86) && 64BIT
+ depends on (X86 || UML_X86) && 64BIT && CRYPTO
select CRYPTO_THREEFISH
select CRYPTO_HASH
help
@@ -17,7 +17,7 @@ config CRYPTO_SKEIN
config CRYPTO_THREEFISH
bool "Threefish tweakable block cipher"
- depends on (X86 || UML_X86) && 64BIT
+ depends on (X86 || UML_X86) && 64BIT && CRYPTO
select CRYPTO_ALGAPI
help
Threefish cipher algorithm is the tweakable block cipher underneath
--
1.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: crypto: skein: depend upon CRYPTO
2014-04-25 16:45 ` [PATCH] staging: crypto: skein: depend upon CRYPTO Jason Cooper
@ 2014-04-28 21:38 ` Marek Vasut
0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2014-04-28 21:38 UTC (permalink / raw)
To: Jason Cooper
Cc: Greg Kroah-Hartman, Fengguang Wu, kbuild-all, linux-crypto,
linux-kernel
On Friday, April 25, 2014 at 06:45:09 PM, Jason Cooper wrote:
> Fengguang's randconfig kernel build tester discovered the following
> warnings:
>
> warning: (CRYPTO_THREEFISH) selects CRYPTO_ALGAPI which has unmet direct
> dependencies (CRYPTO) warning: (DM_VERITY && CRYPTO_SKEIN) selects
> CRYPTO_HASH which has unmet direct dependencies (CRYPTO)
>
> Fix this in the Kconfig by depending on CRYPTO.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Reviewed-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-28 21:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140425151554.GB31117@localhost>
2014-04-25 16:45 ` [PATCH] staging: crypto: skein: depend upon CRYPTO Jason Cooper
2014-04-28 21:38 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).