linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: "Matthias-Christian Ott" <ott@mirix.org>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: user - Allow CRYPTO_MSG_GETALG without CAP_NET_ADMIN
Date: Thu, 1 May 2014 12:53:25 +0200	[thread overview]
Message-ID: <201405011253.25329.marex@denx.de> (raw)
In-Reply-To: <53614DBC.9090304@mirix.org>

On Wednesday, April 30, 2014 at 09:23:40 PM, Matthias-Christian Ott wrote:
> On 04/28/14 23:37, Marek Vasut wrote:
> > On Friday, April 25, 2014 at 12:51:06 AM, Matthias-Christian Ott wrote:
> >> CRYPTO_USER requires CAP_NET_ADMIN for all operations. Most information
> >> provided by CRYPTO_MSG_GETALG is also accessible through /proc/modules
> >> and AF_ALG. CRYPTO_MSG_GETALG should not require CAP_NET_ADMIN so that
> >> processes without CAP_NET_ADMIN can use CRYPTO_MSG_GETALG to get cipher
> >> details, such as cipher priorities, for AF_ALG.
> >> 
> >> Signed-off-by: Matthias-Christian Ott <ott@mirix.org>
> >> ---
> >> 
> >>  crypto/crypto_user.c | 12 +++++++++---
> >>  1 file changed, 9 insertions(+), 3 deletions(-)
> > 
> > Can you please submit the patch using git send-email so we can properly
> > review it?
> 
> git-send-email or more specifically Net::SMTP only works with IPv4. The
> SMTP server I use for submission only listens IPv6 addresses. Moreover,
> TLS seems broken. I patched Net::SMTP to use IO::Socket::INET6 but gave
> up because of the TLS issues and used git format-patch and git imap-send.

You can always set up a separate mailserver or use one of the many free-to-use 
mailservers to follow the agreed-upon submission process, right?

Of course, patches for Net::SMTP are welcome.

Best regards,
Marek Vasut

  reply	other threads:[~2014-05-01 14:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-05 14:43 Why does CRYPTO_USER require CAP_NET_ADMIN? Matthias-Christian Ott
2014-04-24 22:51 ` [PATCH] crypto: user - Allow CRYPTO_MSG_GETALG without CAP_NET_ADMIN Matthias-Christian Ott
2014-04-28 21:37   ` Marek Vasut
2014-04-30 19:23     ` Matthias-Christian Ott
2014-05-01 10:53       ` Marek Vasut [this message]
2014-05-03 23:45         ` Matthias-Christian Ott
2014-05-08 14:01   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201405011253.25329.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-crypto@vger.kernel.org \
    --cc=ott@mirix.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).