linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] RSA: Don't select non-existent symbol
@ 2014-05-22 16:25 Jean Delvare
  2014-05-24 12:01 ` Marek Vasut
  2014-05-30  9:18 ` Herbert Xu
  0 siblings, 2 replies; 6+ messages in thread
From: Jean Delvare @ 2014-05-22 16:25 UTC (permalink / raw)
  To: linux-crypto; +Cc: Herbert Xu, David S. Miller

You can select MPILIB_EXTRA all you want, it doesn't exist ;-)

Surprised kconfig doesn't complain about that...

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
---
 crypto/asymmetric_keys/Kconfig |    1 -
 1 file changed, 1 deletion(-)

--- linux-3.15-rc6.orig/crypto/asymmetric_keys/Kconfig	2014-03-31 05:40:15.000000000 +0200
+++ linux-3.15-rc6/crypto/asymmetric_keys/Kconfig	2014-05-22 18:17:27.988688934 +0200
@@ -22,7 +22,6 @@ config ASYMMETRIC_PUBLIC_KEY_SUBTYPE
 
 config PUBLIC_KEY_ALGO_RSA
 	tristate "RSA public-key algorithm"
-	select MPILIB_EXTRA
 	select MPILIB
 	help
 	  This option enables support for the RSA algorithm (PKCS#1, RFC3447).

-- 
Jean Delvare
SUSE L3 Support

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] RSA: Don't select non-existent symbol
  2014-05-22 16:25 Jean Delvare
@ 2014-05-24 12:01 ` Marek Vasut
  2014-05-30  9:18 ` Herbert Xu
  1 sibling, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2014-05-24 12:01 UTC (permalink / raw)
  To: Jean Delvare; +Cc: linux-crypto, Herbert Xu, David S. Miller

On Thursday, May 22, 2014 at 06:25:15 PM, Jean Delvare wrote:
> You can select MPILIB_EXTRA all you want, it doesn't exist ;-)
> 
> Surprised kconfig doesn't complain about that...
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> ---
>  crypto/asymmetric_keys/Kconfig |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- linux-3.15-rc6.orig/crypto/asymmetric_keys/Kconfig	2014-03-31
> 05:40:15.000000000 +0200 +++
> linux-3.15-rc6/crypto/asymmetric_keys/Kconfig	2014-05-22
> 18:17:27.988688934 +0200 @@ -22,7 +22,6 @@ config
> ASYMMETRIC_PUBLIC_KEY_SUBTYPE
> 
>  config PUBLIC_KEY_ALGO_RSA
>  	tristate "RSA public-key algorithm"
> -	select MPILIB_EXTRA
>  	select MPILIB
>  	help
>  	  This option enables support for the RSA algorithm (PKCS#1, RFC3447).

Nice find.

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] RSA: Don't select non-existent symbol
  2014-05-22 16:25 Jean Delvare
  2014-05-24 12:01 ` Marek Vasut
@ 2014-05-30  9:18 ` Herbert Xu
  2014-05-30 10:50   ` Jean Delvare
  2014-05-30 11:29   ` David Howells
  1 sibling, 2 replies; 6+ messages in thread
From: Herbert Xu @ 2014-05-30  9:18 UTC (permalink / raw)
  To: Jean Delvare; +Cc: linux-crypto, David S. Miller, David Howells

On Thu, May 22, 2014 at 06:25:15PM +0200, Jean Delvare wrote:
> You can select MPILIB_EXTRA all you want, it doesn't exist ;-)
> 
> Surprised kconfig doesn't complain about that...
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>

This patch should go to David Howells <dhowells@redhat.com>

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] RSA: Don't select non-existent symbol
  2014-05-30  9:18 ` Herbert Xu
@ 2014-05-30 10:50   ` Jean Delvare
  2014-05-30 11:29   ` David Howells
  1 sibling, 0 replies; 6+ messages in thread
From: Jean Delvare @ 2014-05-30 10:50 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-crypto, David S. Miller, David Howells

Hi Herbert,

On Fri, 30 May 2014 17:18:54 +0800, Herbert Xu wrote:
> On Thu, May 22, 2014 at 06:25:15PM +0200, Jean Delvare wrote:
> > You can select MPILIB_EXTRA all you want, it doesn't exist ;-)
> > 
> > Surprised kconfig doesn't complain about that...
> > 
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Cc: "David S. Miller" <davem@davemloft.net>
> 
> This patch should go to David Howells <dhowells@redhat.com>

Why? How could I find out? scripts/get_maintainer.pl says David Miller
and you. If David Howells really wants to handle this, he should add an
appropriate entry in MAINTAINERS.

-- 
Jean Delvare
SUSE L3 Support

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] RSA: Don't select non-existent symbol
  2014-05-30  9:18 ` Herbert Xu
  2014-05-30 10:50   ` Jean Delvare
@ 2014-05-30 11:29   ` David Howells
  1 sibling, 0 replies; 6+ messages in thread
From: David Howells @ 2014-05-30 11:29 UTC (permalink / raw)
  To: Jean Delvare; +Cc: dhowells, Herbert Xu, linux-crypto, David S. Miller

Jean Delvare <jdelvare@suse.de> wrote:

> > This patch should go to David Howells <dhowells@redhat.com>
> 
> Why? How could I find out?

Try "git log".

David

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] RSA: Don't select non-existent symbol
@ 2014-05-30 12:02 Jean Delvare
  0 siblings, 0 replies; 6+ messages in thread
From: Jean Delvare @ 2014-05-30 12:02 UTC (permalink / raw)
  To: linux-crypto, David Howells; +Cc: Herbert Xu, David S. Miller, Marek Vasut

You can select MPILIB_EXTRA all you want, it doesn't exist ;-)

Surprised kconfig doesn't complain about that...

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Acked-by: Marek Vasut <marex@denx.de>
Cc: David Howells <dhowells@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
---
Resent with David Howells added to Cc.

 crypto/asymmetric_keys/Kconfig |    1 -
 1 file changed, 1 deletion(-)

--- linux-3.15-rc6.orig/crypto/asymmetric_keys/Kconfig	2014-03-31 05:40:15.000000000 +0200
+++ linux-3.15-rc6/crypto/asymmetric_keys/Kconfig	2014-05-22 18:17:27.988688934 +0200
@@ -22,7 +22,6 @@ config ASYMMETRIC_PUBLIC_KEY_SUBTYPE
 
 config PUBLIC_KEY_ALGO_RSA
 	tristate "RSA public-key algorithm"
-	select MPILIB_EXTRA
 	select MPILIB
 	help
 	  This option enables support for the RSA algorithm (PKCS#1, RFC3447).


-- 
Jean Delvare
SUSE L3 Support

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-05-30 12:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-30 12:02 [PATCH] RSA: Don't select non-existent symbol Jean Delvare
  -- strict thread matches above, loose matches on Subject: below --
2014-05-22 16:25 Jean Delvare
2014-05-24 12:01 ` Marek Vasut
2014-05-30  9:18 ` Herbert Xu
2014-05-30 10:50   ` Jean Delvare
2014-05-30 11:29   ` David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).