linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] crypto: caam - remove duplicate FIFOST_CONT_MASK define
@ 2014-06-09 15:19 Dan Carpenter
  2014-06-12 23:18 ` Kim Phillips
  2014-06-14  3:45 ` Marek Vasut
  0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-06-09 15:19 UTC (permalink / raw)
  To: Alex Porosanu; +Cc: Herbert Xu, linux-crypto, kernel-janitors

The FIFOST_CONT_MASK define is cut and pasted twice so we can delete the
second instance.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/crypto/caam/desc.h b/drivers/crypto/caam/desc.h
index 7e4500f..d397ff9 100644
--- a/drivers/crypto/caam/desc.h
+++ b/drivers/crypto/caam/desc.h
@@ -321,7 +321,6 @@ struct sec4_sg_entry {
 /* Continue - Not the last FIFO store to come */
 #define FIFOST_CONT_SHIFT	23
 #define FIFOST_CONT_MASK	(1 << FIFOST_CONT_SHIFT)
-#define FIFOST_CONT_MASK	(1 << FIFOST_CONT_SHIFT)
 
 /*
  * Extended Length - use 32-bit extended length that

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [patch] crypto: caam - remove duplicate FIFOST_CONT_MASK define
  2014-06-09 15:19 [patch] crypto: caam - remove duplicate FIFOST_CONT_MASK define Dan Carpenter
@ 2014-06-12 23:18 ` Kim Phillips
  2014-06-20 18:42   ` Herbert Xu
  2014-06-14  3:45 ` Marek Vasut
  1 sibling, 1 reply; 4+ messages in thread
From: Kim Phillips @ 2014-06-12 23:18 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Alex Porosanu, Herbert Xu, linux-crypto, kernel-janitors

On Mon, 9 Jun 2014 18:19:41 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The FIFOST_CONT_MASK define is cut and pasted twice so we can delete the
> second instance.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Kim Phillips <kim.phillips@freescale.com>

Thanks,

Kim

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] crypto: caam - remove duplicate FIFOST_CONT_MASK define
  2014-06-09 15:19 [patch] crypto: caam - remove duplicate FIFOST_CONT_MASK define Dan Carpenter
  2014-06-12 23:18 ` Kim Phillips
@ 2014-06-14  3:45 ` Marek Vasut
  1 sibling, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2014-06-14  3:45 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Alex Porosanu, Herbert Xu, linux-crypto, kernel-janitors

On Monday, June 09, 2014 at 05:19:41 PM, Dan Carpenter wrote:
> The FIFOST_CONT_MASK define is cut and pasted twice so we can delete the
> second instance.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/crypto/caam/desc.h b/drivers/crypto/caam/desc.h
> index 7e4500f..d397ff9 100644
> --- a/drivers/crypto/caam/desc.h
> +++ b/drivers/crypto/caam/desc.h
> @@ -321,7 +321,6 @@ struct sec4_sg_entry {
>  /* Continue - Not the last FIFO store to come */
>  #define FIFOST_CONT_SHIFT	23
>  #define FIFOST_CONT_MASK	(1 << FIFOST_CONT_SHIFT)
> -#define FIFOST_CONT_MASK	(1 << FIFOST_CONT_SHIFT)
> 
>  /*
>   * Extended Length - use 32-bit extended length that

Sigh, I'm surprised the compiler didn't choke about this.

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] crypto: caam - remove duplicate FIFOST_CONT_MASK define
  2014-06-12 23:18 ` Kim Phillips
@ 2014-06-20 18:42   ` Herbert Xu
  0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2014-06-20 18:42 UTC (permalink / raw)
  To: Kim Phillips; +Cc: Dan Carpenter, Alex Porosanu, linux-crypto, kernel-janitors

On Thu, Jun 12, 2014 at 06:18:12PM -0500, Kim Phillips wrote:
> On Mon, 9 Jun 2014 18:19:41 +0300
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
> 
> > The FIFOST_CONT_MASK define is cut and pasted twice so we can delete the
> > second instance.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Acked-by: Kim Phillips <kim.phillips@freescale.com>

Patch applied.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-06-20 18:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-09 15:19 [patch] crypto: caam - remove duplicate FIFOST_CONT_MASK define Dan Carpenter
2014-06-12 23:18 ` Kim Phillips
2014-06-20 18:42   ` Herbert Xu
2014-06-14  3:45 ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).