From: Marek Vasut <marex@denx.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alex Porosanu <alexandru.porosanu@freescale.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] crypto: caam - remove duplicate FIFOST_CONT_MASK define
Date: Sat, 14 Jun 2014 05:45:54 +0200 [thread overview]
Message-ID: <201406140545.54199.marex@denx.de> (raw)
In-Reply-To: <20140609151941.GN9600@mwanda>
On Monday, June 09, 2014 at 05:19:41 PM, Dan Carpenter wrote:
> The FIFOST_CONT_MASK define is cut and pasted twice so we can delete the
> second instance.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/crypto/caam/desc.h b/drivers/crypto/caam/desc.h
> index 7e4500f..d397ff9 100644
> --- a/drivers/crypto/caam/desc.h
> +++ b/drivers/crypto/caam/desc.h
> @@ -321,7 +321,6 @@ struct sec4_sg_entry {
> /* Continue - Not the last FIFO store to come */
> #define FIFOST_CONT_SHIFT 23
> #define FIFOST_CONT_MASK (1 << FIFOST_CONT_SHIFT)
> -#define FIFOST_CONT_MASK (1 << FIFOST_CONT_SHIFT)
>
> /*
> * Extended Length - use 32-bit extended length that
Sigh, I'm surprised the compiler didn't choke about this.
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
prev parent reply other threads:[~2014-06-14 3:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 15:19 [patch] crypto: caam - remove duplicate FIFOST_CONT_MASK define Dan Carpenter
2014-06-12 23:18 ` Kim Phillips
2014-06-20 18:42 ` Herbert Xu
2014-06-14 3:45 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201406140545.54199.marex@denx.de \
--to=marex@denx.de \
--cc=alexandru.porosanu@freescale.com \
--cc=dan.carpenter@oracle.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).