Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	"David S.Miller" <davem@davemloft.net>,
	Chandramouli Narayanan <mouli@linux.intel.com>,
	Vinodh Gopal <vinodh.gopal@intel.com>,
	James Guilford <james.guilford@intel.com>,
	Wajdi Feghali <wajdi.k.feghali@intel.com>,
	Jussi Kivilinna <jussi.kivilinna@iki.fi>,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH v3 1/6] crypto: SHA1 multibuffer crypto hash infrastructure
Date: Sat, 21 Jun 2014 01:57:51 +0800	[thread overview]
Message-ID: <20140620175751.GA2802@gondor.apana.org.au> (raw)
In-Reply-To: <1402520625.2970.537.camel@schen9-DESK>

On Wed, Jun 11, 2014 at 02:03:45PM -0700, Tim Chen wrote:
>
> diff --git a/crypto/shash.c b/crypto/shash.c
> index 929058a..234ece0 100644
> --- a/crypto/shash.c
> +++ b/crypto/shash.c
> @@ -271,6 +271,18 @@ static int shash_async_finup(struct ahash_request *req)
>  	return shash_ahash_finup(req, desc);
>  }
>  
> +int shash_ahash_mcryptd_digest(struct ahash_request *req,
> +			       struct shash_desc *desc)
> +{
> +	int err;
> +
> +	err = crypto_shash_init(desc) ?:
> +	      shash_ahash_mcryptd_finup(req, desc);
> +
> +	return err;
> +}
> +EXPORT_SYMBOL_GPL(shash_ahash_mcryptd_digest);
> +

This bit causes your patch to not build for me.

Please fix and resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2014-06-20 17:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1402491749.git.tim.c.chen@linux.intel.com>
2014-06-11 21:03 ` [PATCH v3 0/6] crypto: SHA1 multibuffer implementation Tim Chen
2014-06-11 21:03 ` [PATCH v3 1/6] crypto: SHA1 multibuffer crypto hash infrastructure Tim Chen
2014-06-20 17:57   ` Herbert Xu [this message]
2014-06-20 19:15     ` Tim Chen
2014-06-23 19:48     ` Tim Chen
2014-06-11 21:03 ` [PATCH v3 2/6] crypto: SHA1 multibuffer algorithm data structures Tim Chen
2014-06-11 21:03 ` [PATCH v3 3/6] crypto: SHA1 multibuffer submit and flush routines for AVX2 Tim Chen
2014-06-11 21:04 ` [PATCH v3 4/6] crypto: SHA1 multibuffer crypto computation (x8 AVX2) Tim Chen
2014-06-11 21:04 ` [PATCH v3 5/6] crypto: SHA1 multibuffer scheduler Tim Chen
2014-06-11 21:04 ` [PATCH v3 6/6] crypto: SHA1 multibuffer - flush the jobs before going into idle Tim Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140620175751.GA2802@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=hpa@zytor.com \
    --cc=james.guilford@intel.com \
    --cc=jussi.kivilinna@iki.fi \
    --cc=linux-crypto@vger.kernel.org \
    --cc=mouli@linux.intel.com \
    --cc=tim.c.chen@linux.intel.com \
    --cc=vinodh.gopal@intel.com \
    --cc=wajdi.k.feghali@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox