Re: [PATCH v5 3/7] crypto: SHA1 multibuffer crypto opportunistic flush

[Peter Zijlstra <peterz@infradead.org>]

On Tue, Jul 22, 2014 at 03:09:35PM -0700, Tim Chen wrote:
> The crypto daemon can take advantage of available cpu
> cycles to flush any unfinished jobs if it is the
> only task running on the cpu, and there are no more crypto
> jobs to process.

You conveniently forgot to mention energy efficiency, and the problem
with short idle durations. Although the latter issue seems overshadowed
by the not so very robust idle detection.

In any case, same as the other patch, you can get similarly inconclusive
semantics without single_task_running().

> Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
> ---
>  crypto/mcryptd.c | 39 ++++++++++++++++++++++++++++++++++++---
>  1 file changed, 36 insertions(+), 3 deletions(-)

> +/*
> + * Called in workqueue context, do one real cryption work (via
>   * req->complete) and reschedule itself if there are more work to
> - * do. */
> + * do.
> + */

See, this should've been in the previous patch :-)