* [cryptodev PATCH] qat: cleanup unnecessary break checkpatch warning
@ 2014-10-15 18:33 Bruce Allan
2014-10-24 14:55 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Bruce Allan @ 2014-10-15 18:33 UTC (permalink / raw)
To: linux-crypto; +Cc: tadeusz.struk, herbert, davem, qat-linux
WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
#472: FILE: drivers/crypto/qat/qat_common/qat_algs.c:472:
+ goto bad_key;
+ break;
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
---
drivers/crypto/qat/qat_common/qat_algs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/qat/qat_common/qat_algs.c b/drivers/crypto/qat/qat_common/qat_algs.c
index 3e26fa2..e03afe9 100644
--- a/drivers/crypto/qat/qat_common/qat_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_algs.c
@@ -469,7 +469,6 @@ static int qat_alg_init_sessions(struct qat_alg_session_ctx *ctx,
break;
default:
goto bad_key;
- break;
}
if (qat_alg_init_enc_session(ctx, alg, &keys))
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [cryptodev PATCH] qat: cleanup unnecessary break checkpatch warning
2014-10-15 18:33 [cryptodev PATCH] qat: cleanup unnecessary break checkpatch warning Bruce Allan
@ 2014-10-24 14:55 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2014-10-24 14:55 UTC (permalink / raw)
To: Bruce Allan; +Cc: linux-crypto, tadeusz.struk, davem, qat-linux
On Wed, Oct 15, 2014 at 11:33:27AM -0700, Bruce Allan wrote:
> WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
> #472: FILE: drivers/crypto/qat/qat_common/qat_algs.c:472:
> + goto bad_key;
> + break;
>
> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-24 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-15 18:33 [cryptodev PATCH] qat: cleanup unnecessary break checkpatch warning Bruce Allan
2014-10-24 14:55 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).