From: Herbert Xu <herbert@gondor.apana.org.au>
To: Bruce Allan <bruce.w.allan@intel.com>
Cc: linux-crypto@vger.kernel.org, tadeusz.struk@intel.com,
davem@davemloft.net, qat-linux@intel.com
Subject: Re: [cryptodev PATCH] qat: cleanup coccicheck warning - NULL check before freeing functions
Date: Fri, 24 Oct 2014 22:54:57 +0800 [thread overview]
Message-ID: <20141024145457.GD21055@gondor.apana.org.au> (raw)
In-Reply-To: <20141015183321.23860.21499.stgit@gitlad.jf.intel.com>
On Wed, Oct 15, 2014 at 11:33:21AM -0700, Bruce Allan wrote:
> Analyzing with coccinelle MODE=report...
>
> Please check for false positives in the output before submitting a patch.
> When using "patch" mode, carefully review the patch before submitting it.
>
> drivers/crypto/qat/qat_dh895xcc/adf_isr.c:191:3-8: WARNING: NULL check
> before freeing functions like kfree, debugfs_remove,
> debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider
> reorganizing relevant code to avoid passing NULL values.
>
> drivers/crypto/qat/qat_dh895xcc/adf_isr.c:208:3-8: WARNING: NULL check
> before freeing functions like kfree, debugfs_remove,
> debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider
> reorganizing relevant code to avoid passing NULL values.
>
> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2014-10-24 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 18:33 [cryptodev PATCH] qat: cleanup coccicheck warning - NULL check before freeing functions Bruce Allan
2014-10-24 14:54 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024145457.GD21055@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).