From: Herbert Xu <herbert@gondor.apana.org.au>
To: Nickolaus Woodruff <nickolauswoodruff@gmail.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: drbg: use memzero_explicit() for clearing sensitive data
Date: Wed, 26 Nov 2014 20:03:36 +0800 [thread overview]
Message-ID: <20141126120336.GA16375@gondor.apana.org.au> (raw)
In-Reply-To: <20141124152116.GA31106@nick-ThinkPad-T430s>
On Mon, Nov 24, 2014 at 10:21:16AM -0500, Nickolaus Woodruff wrote:
> diff --git a/include/crypto/drbg.h b/include/crypto/drbg.h
> index 5186f75..13471a2 100644
> --- a/include/crypto/drbg.h
> +++ b/include/crypto/drbg.h
> @@ -45,6 +45,7 @@
> #include <crypto/hash.h>
> #include <linux/module.h>
> #include <linux/crypto.h>
> +#include <linux/string.h>
Why are you adding the inclusion to drbg.h? This file is for
users of drbg. Please add it to drbg.c instead.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2014-11-26 12:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 15:21 [PATCH] crypto: drbg: use memzero_explicit() for clearing sensitive data Nickolaus Woodruff
2014-11-26 12:03 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126120336.GA16375@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=nickolauswoodruff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox