From: Herbert Xu <herbert@gondor.apana.org.au>
To: Nickolaus Woodruff <nickolauswoodruff@gmail.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2] crypto: drbg: use memzero_explicit() for clearing sensitive data
Date: Mon, 5 Jan 2015 10:45:29 +1100 [thread overview]
Message-ID: <20150104234529.GA20989@gondor.apana.org.au> (raw)
In-Reply-To: <20141127143302.GB25101@gondor.apana.org.au>
On Thu, Nov 27, 2014 at 10:33:02PM +0800, Herbert Xu wrote:
> On Wed, Nov 26, 2014 at 01:40:57PM -0500, Nickolaus Woodruff wrote:
> > Compiler dead store optimization can sometimes remove final calls
> > to memset() used to clear sensitive data at the end of a function.
> > Replace trailing memset() calls with memzero_explicit() to
> > preclude unwanted removal.
> >
> > Signed-off-by: Nickolaus Woodruff <nickolauswoodruff@gmail.com>
>
> Patch applied. Thanks!
Actually I'm reverting this because the patch was bogus. None
of the data zeroed are on the stack.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2015-01-04 23:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 18:40 [PATCH v2] crypto: drbg: use memzero_explicit() for clearing sensitive data Nickolaus Woodruff
2014-11-27 14:33 ` Herbert Xu
2015-01-04 23:45 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150104234529.GA20989@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=nickolauswoodruff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox