From: "George Spelvin" <linux@horizon.com>
To: keescook@chromium.org, minipli@googlemail.com
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
linux@horizon.com
Subject: Re: [BISECTED] 4943ba16 ("include crypto- module prefix") breaks wifi
Date: 17 Feb 2015 12:47:40 -0500 [thread overview]
Message-ID: <20150217174740.31169.qmail@ns.horizon.com> (raw)
In-Reply-To: <CAGXu5jKMX+DxPQo=BstEKjyWxvLtnHcG44qyMN=os-U4NjM=Kg@mail.gmail.com>
> And now my head-scratching: your bisect shows that v3.19-rc7 fails,
> but that prior to 4943ba16bbc2, things work correctly? As in, when
> _only_ 5d26a105b5a7 is in your tree things _work_?
Basically, yes. v3.19-rc7 fails with basically the same symptoms:
wpa_supplicant keeps looping trying to associate. I haven't compared
the log messages line-by-line.
It appears that it negotiates a crypto key and then fails to pass
it down to the kernel.
I haven't tested 5d26a105b5a7 specifically (when you say "_only_
5d26a105b5a7 is in your tree", do you mean that state, or that commit
cherry-picked?), but 4 commits later (476c7fe20f30) did get tested,
and it worked. (In fact, that was the final test in my bisect
process; once I typed "git bisect good", things worked.)
Also, one more detail:
- When I changed CTR and CCM from =m to =y, things started working.
Perhaps it's the unexpected case of a module using a static algorithm?
Anyway, let me collect more information before you put more time into
it.
> Could you rename and instrument your /sbin/modprobe to do something like:
>
> #!/bin/sh
> echo "$@" >> /root/modprobe.log
> exec /sbin/modprobe.bin "$@"
>
> Perhaps there's something being explicitly requested rather than
> having it be kernel auto-loaded?
Glad to. Thanks for the pointer!
Unless you say otherwise, I'll probably test on 3.19 release, since that
seems the most useful baseline for future repair.
next prev parent reply other threads:[~2015-02-17 17:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 3:09 [BISECTED] 4943ba16 ("include crypto- module prefix") breaks wifi George Spelvin
2015-02-17 6:49 ` Mathias Krause
2015-02-17 16:43 ` Kees Cook
2015-02-17 17:47 ` George Spelvin [this message]
2015-02-18 6:34 ` George Spelvin
2015-02-18 7:56 ` Mathias Krause
2015-02-25 21:50 ` Kees Cook
2015-04-30 11:00 ` George Spelvin
2015-06-05 23:07 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150217174740.31169.qmail@ns.horizon.com \
--to=linux@horizon.com \
--cc=herbert@gondor.apana.org.au \
--cc=keescook@chromium.org \
--cc=linux-crypto@vger.kernel.org \
--cc=minipli@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox