* [PATCH] crypto: qat - remove incorrect __exit markup
@ 2015-03-09 20:25 Dmitry Torokhov
2015-03-11 14:13 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2015-03-09 20:25 UTC (permalink / raw)
To: Herbert Xu
Cc: Tadeusz Struk, Allan, Bruce W, qat-linux, linux-crypto,
linux-kernel
PCI bus is hot-pluggable, and even if it wasn't one can still unbind the
device from driver via sysfs, so we should not make driver's remove
method as __exit.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
index 8ffdb95..e7af9d5 100644
--- a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
+++ b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
@@ -379,7 +379,7 @@ out_err:
return ret;
}
-static void __exit adf_remove(struct pci_dev *pdev)
+static void adf_remove(struct pci_dev *pdev)
{
struct adf_accel_dev *accel_dev = adf_devmgr_pci_to_accel_dev(pdev);
--
2.2.0.rc0.207.ga3a616c
--
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] crypto: qat - remove incorrect __exit markup
2015-03-09 20:25 [PATCH] crypto: qat - remove incorrect __exit markup Dmitry Torokhov
@ 2015-03-11 14:13 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2015-03-11 14:13 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Tadeusz Struk, Allan, Bruce W, qat-linux, linux-crypto,
linux-kernel
On Mon, Mar 09, 2015 at 01:25:49PM -0700, Dmitry Torokhov wrote:
> PCI bus is hot-pluggable, and even if it wasn't one can still unbind the
> device from driver via sysfs, so we should not make driver's remove
> method as __exit.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-11 14:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-09 20:25 [PATCH] crypto: qat - remove incorrect __exit markup Dmitry Torokhov
2015-03-11 14:13 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).