Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

Jason Cooper
2015-04-17T10:59:57Z

Hey Boris,

On Fri, Apr 17, 2015 at 10:39:46AM +0200, Boris Brezillon wrote:
> On Fri, 17 Apr 2015 10:33:56 +0200 Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> > On Mon, 13 Apr 2015 20:11:46 +0000 Jason Cooper <jason@lakedaemon.net> wrote:
> > > >
> > > > > I'd appreciate if we'd look into it. I understand from on-list and
> > > > > off-list discussion that the rewrite was unavoidable. So I'm willing to
> > > > > concede that. Giving people time to migrate from old to new while still
> > > > > being able to update for other security fixes seems reasonable.
> > > >
> > > > Jason, what do you think of the approach above?
> > >
> > > I say keep it simple. We shouldn't use the DT changes to trigger one
> > > vice the other. We need to be able to build both, but only load one at
> > > a time. If that's anything other than simple to do, then we make it a
> > > Kconfig binary choice and move on.
> >
> > Actually I was planning to handle it with a Kconfig dependency rule
> > (NEW_DRIVER depends on !OLD_DRIVER and OLD_DRIVER depends
> > on !NEW_DRIVER).
> > I don't know how to make it a runtime check without adding new
> > compatible strings for the kirkwood, dove and orion platforms, and I'm
> > sure sure this is a good idea.
> ^ not
>
> > Do you have any ideas ?

I'm kinda wrapped up with dayjob stuff atm... But I'd look at the wireless
drivers. eg b43, b43legacy, brcm80211. There are devices they overlap for.
So, they need to deconflict in some way.

thx,

Jason.