Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephan Mueller <smueller@chronox.de>
Cc: Theodore Ts'o <tytso@mit.edu>, Paul Bolle <pebolle@tiscali.it>,
	Andreas Steffen <andreas.steffen@strongswan.org>,
	Sandy Harris <sandyinchina@gmail.com>,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v4 0/6] Seeding DRBG with more entropy
Date: Mon, 4 May 2015 14:13:51 +0800	[thread overview]
Message-ID: <20150504061350.GA25540@gondor.apana.org.au> (raw)
In-Reply-To: <9802019.GiEn27gNxE@tauon>

On Mon, May 04, 2015 at 07:40:12AM +0200, Stephan Mueller wrote:
> 
> I am not sure that this approach is helpful, because the suggested approach 
> implies using a seeded DRNG and the used get_random_bytes already operates as 
> a (not always seeded) DRNG. If we have a blocking interface in the kernel, I 
> would recommend to make it identical to /dev/random. With the suggested 
> seeding approach for DRBG, we definitely have seed data available to start 
> with. Therefore, re-seeding it from another seeded DRNG (i.e. the nonblocking 
> pool after it is initialized) may not give us too much extra.

My main concern with your original approach was precisely the
fact that get_random_bytes may be called before the before the
kernel pool is ready.  So Ted's solution solves that perfectly.

Please do what Ted says and we can all move forward.

Thanks!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2015-05-04  6:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-03 15:33 [PATCH v4 0/6] Seeding DRBG with more entropy Stephan Mueller
2015-05-03 15:33 ` [PATCH v4 1/6] random: Addition of kernel_pool Stephan Mueller
2015-05-03 15:33 ` [PATCH v4 2/6] random: Async and sync API for accessing kernel_pool Stephan Mueller
2015-05-04 10:22   ` Sandy Harris
2015-05-03 15:34 ` [PATCH v4 3/6] crypto: drbg - prepare for async seeding Stephan Mueller
2015-05-03 15:34 ` [PATCH v4 4/6] crypto: drbg - add async seeding operation Stephan Mueller
2015-05-03 15:35 ` [PATCH v4 5/6] crypto: drbg - use Jitter RNG to obtain seed Stephan Mueller
2015-05-03 15:36 ` [PATCH v4 6/6] crypto: add jitterentropy RNG Stephan Mueller
2015-05-03 20:58 ` [PATCH v4 0/6] Seeding DRBG with more entropy Theodore Ts'o
2015-05-04  5:40   ` Stephan Mueller
2015-05-04  6:13     ` Herbert Xu [this message]
2015-05-04 23:12     ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150504061350.GA25540@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=andreas.steffen@strongswan.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.it \
    --cc=sandyinchina@gmail.com \
    --cc=smueller@chronox.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox