From: Herbert Xu <herbert@gondor.apana.org.au>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, Arnaud Ebalard <arno@natisbad.org>,
Tawfik Bayouk <tawfik@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Eran Ben-Avi <benavi@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Imre Kaloz <kaloz@openwrt.org>
Subject: Re: [PATCH v5 04/14] crypto: add a new driver for Marvell's CESA
Date: Wed, 17 Jun 2015 13:58:24 +0800 [thread overview]
Message-ID: <20150617055824.GA9155@gondor.apana.org.au> (raw)
In-Reply-To: <1434448748-10828-5-git-send-email-boris.brezillon@free-electrons.com>
On Tue, Jun 16, 2015 at 11:58:58AM +0200, Boris Brezillon wrote:
>
> +config CRYPTO_DEV_MARVELL_CESA
> + tristate "New Marvell's Cryptographic Engine driver"
> + depends on (PLAT_ORION || ARCH_MVEBU || COMPILE_TEST) && HAS_DMA && HAS_IOMEM
> + select CRYPTO_ALGAPI
> + select CRYPTO_AES
> + select CRYPTO_DES
> + select CRYPTO_BLKCIPHER2
> + select CRYPTO_HASH
While you're fixing the DMA issue, could you also replace BLKCIPHER2
with BLKCIPHER and kill the select on ALGAPI? BLKCIPHER2 is internal
to the crypto API and should not be used elsewhere while ALGAPI is
only meant to be selected by crypto types such as BLKCIPHER.
I know the existing driver does this too and I will fix that now.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2015-06-17 5:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 9:58 [PATCH v5 00/14] crypto: add a new driver for Marvell's CESA Boris Brezillon
2015-06-16 9:58 ` [PATCH v5 01/14] crypto: mv_cesa: document the clocks property Boris Brezillon
2015-06-16 9:58 ` [PATCH v5 02/14] crypto: mv_cesa: use gen_pool to reserve the SRAM memory region Boris Brezillon
2015-06-16 9:58 ` [PATCH v5 03/14] crypto: mv_cesa: explicitly define kirkwood and dove compatible strings Boris Brezillon
2015-06-16 9:58 ` [PATCH v5 04/14] crypto: add a new driver for Marvell's CESA Boris Brezillon
2015-06-17 5:58 ` Herbert Xu [this message]
[not found] ` <20150617055824.GA9155-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-06-17 6:58 ` crypto: drivers - Fix Kconfig selects Herbert Xu
2015-06-17 7:15 ` [PATCH v5 04/14] crypto: add a new driver for Marvell's CESA Boris Brezillon
[not found] ` <1434448748-10828-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-06-16 9:58 ` [PATCH v5 05/14] crypto: marvell/CESA: add TDMA support Boris Brezillon
[not found] ` <1434448748-10828-6-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-06-17 5:05 ` Herbert Xu
2015-06-17 5:56 ` Herbert Xu
2015-06-17 7:15 ` Boris Brezillon
2015-06-17 7:18 ` Herbert Xu
[not found] ` <20150617071829.GA9895-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-06-17 7:37 ` Boris Brezillon
2015-06-16 9:59 ` [PATCH v5 09/14] crypto: marvell/CESA: add SHA256 support Boris Brezillon
2015-06-16 9:59 ` [PATCH v5 11/14] crypto: marvell/CESA: add allhwsupport module parameter Boris Brezillon
2015-06-16 9:59 ` [PATCH v5 12/14] crypto: marvell/CESA: add support for Orion SoCs Boris Brezillon
2015-06-16 9:59 ` [PATCH v5 06/14] crypto: marvell/CESA: add DES support Boris Brezillon
2015-06-17 18:07 ` Sandy Harris
2015-06-16 9:59 ` [PATCH v5 07/14] crypto: marvell/CESA: add Triple-DES support Boris Brezillon
2015-06-16 9:59 ` [PATCH v5 08/14] crypto: marvell/CESA: add MD5 support Boris Brezillon
2015-06-16 9:59 ` [PATCH v5 10/14] crypto: marvell/CESA: add support for all armada SoCs Boris Brezillon
2015-06-16 9:59 ` [PATCH v5 13/14] crypto: marvell/CESA: add support for Kirkwood and Dove SoCs Boris Brezillon
2015-06-16 9:59 ` [PATCH v5 14/14] crypto: marvell/CESA: add DT bindings documentation Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617055824.GA9155@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=arno@natisbad.org \
--cc=benavi@marvell.com \
--cc=boris.brezillon@free-electrons.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregory.clement@free-electrons.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kaloz@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nadavh@marvell.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).