linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Leonidas S. Barbosa" <leosilva@linux.vnet.ibm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Fionnuala Gunter <fin@linux.vnet.ibm.com>
Subject: Re: crypto: nx - Fix reentrancy bugs
Date: Tue, 7 Jul 2015 15:48:37 -0300	[thread overview]
Message-ID: <20150707184837.GA9341@bluepex.com> (raw)
In-Reply-To: <20150707093025.GA31368@gondor.apana.org.au>

On Tue, Jul 07, 2015 at 05:30:25PM +0800, Herbert Xu wrote:
> The crypto API allows a single transform to be used by multiple
> threads simultaneously.  For example, IPsec will use a single tfm
> to process packets for a given SA.  As packets may arrive on
> multiple CPUs that tfm must be reentrant.
> 
> The nx driver does try to deal with this by using a spin lock.
> Unfortunately only the basic AES/CBC/ECB algorithms do this in
> the correct way.
> 
> The symptom of these bugs may range from the generation of incorrect
> output to memory corruption.

Is this related with the issue in CTR ouput test#4 too?

Thanks!

  reply	other threads:[~2015-07-07 18:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07  9:30 crypto: nx - Fix reentrancy bugs Herbert Xu
2015-07-07 18:48 ` Leonidas S. Barbosa [this message]
2015-07-07 22:10   ` Herbert Xu
2015-07-08 13:46     ` Leonidas S. Barbosa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150707184837.GA9341@bluepex.com \
    --to=leosilva@linux.vnet.ibm.com \
    --cc=fin@linux.vnet.ibm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).