From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephan Mueller <smueller@chronox.de>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 0/14] crypto: aead - Phase oute seqniv
Date: Fri, 10 Jul 2015 21:39:22 +0800 [thread overview]
Message-ID: <20150710133922.GC17850@gondor.apana.org.au> (raw)
In-Reply-To: <2219094.SOh4kNKiQk@tachyon.chronox.de>
On Thu, Jul 09, 2015 at 01:38:07PM +0200, Stephan Mueller wrote:
>
> Actually, I found a problem that I have overlooked initally: rfc4106-gcm-aesni
> causes a problem. For encryption/decryption with the same tests for other
> rfc4106 implementations, I get an EINVAL.
Did you update your test vectors? The AD must now include the IV.
This is the reason I disabled the AEAD interface in 4.2 by requiring
any exported AEAD algorithm to carry the CRYPTO_ALG_AEAD_NEW flag.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2015-07-10 13:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 23:13 [PATCH 0/14] crypto: aead - Phase oute seqniv Herbert Xu
2015-07-08 23:17 ` [PATCH 1/14] crypto: api - Add instance free function to crypto_type Herbert Xu
2015-07-08 23:17 ` [PATCH 2/14] crypto: aead - Add type-safe function for freeing instances Herbert Xu
2015-07-08 23:17 ` [PATCH 3/14] crypto: pcrypt - Propagate new AEAD implementation flag Herbert Xu
2015-07-08 23:17 ` [PATCH 4/14] crypto: cryptd " Herbert Xu
2015-07-08 23:17 ` [PATCH 5/14] crypto: echainiv - Fix encryption convention Herbert Xu
2015-07-08 23:17 ` [PATCH 6/14] crypto: seqiv - Replace seqniv with seqiv Herbert Xu
2015-07-08 23:17 ` [PATCH 7/14] crypto: aead - Propagate new AEAD implementation flag for IV generators Herbert Xu
2015-07-08 23:17 ` [PATCH 8/14] crypto: testmgr - Disable rfc4106 test and convert test vectors Herbert Xu
2015-07-08 23:17 ` [PATCH 9/14] crypto: tcrypt - Add support for new IV convention Herbert Xu
2015-07-09 7:59 ` Stephan Mueller
2015-07-09 8:00 ` Herbert Xu
2015-07-08 23:17 ` [PATCH 10/14] crypto: aesni - Use " Herbert Xu
2015-07-08 23:17 ` [PATCH 11/14] crypto: gcm " Herbert Xu
2015-07-08 23:17 ` [PATCH 12/14] crypto: nx " Herbert Xu
2015-07-09 6:19 ` Stephan Mueller
2015-07-09 6:56 ` Herbert Xu
2015-07-09 7:07 ` Stephan Mueller
2015-07-09 7:11 ` Herbert Xu
2015-07-08 23:17 ` [PATCH 13/14] crypto: caam " Herbert Xu
2015-07-08 23:17 ` [PATCH 14/14] crypto: testmgr - Reenable rfc4106 test Herbert Xu
2015-07-09 10:19 ` [PATCH 0/14] crypto: aead - Phase oute seqniv Stephan Mueller
2015-07-09 11:38 ` Stephan Mueller
2015-07-10 13:39 ` Herbert Xu [this message]
2015-07-10 17:57 ` Stephan Mueller
2015-07-11 2:39 ` Herbert Xu
2015-07-13 9:09 ` Stephan Mueller
2015-07-13 9:13 ` Herbert Xu
2015-07-13 11:29 ` Stephan Mueller
2015-07-10 13:38 ` Herbert Xu
2015-07-10 18:46 ` Stephan Mueller
2015-07-11 2:37 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710133922.GC17850@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox