Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Tadeusz Struk <tadeusz.struk@intel.com>
To: herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com,
	tadeusz.struk@intel.com
Subject: [PATCH 3/8] crypto: qat - check status returned from crypto_unregister_akcipher
Date: Wed, 09 Sep 2015 09:15:13 -0700	[thread overview]
Message-ID: <20150909161513.2828.43757.stgit@tstruk-mobl1> (raw)
In-Reply-To: <20150909161454.2828.70445.stgit@tstruk-mobl1>

Add status check returned from crypto_unregister_akcipher.

Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
---
 drivers/crypto/qat/qat_common/adf_common_drv.h |    2 +-
 drivers/crypto/qat/qat_common/adf_init.c       |    6 ++----
 drivers/crypto/qat/qat_common/qat_asym_algs.c  |    7 +++++--
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/crypto/qat/qat_common/adf_common_drv.h b/drivers/crypto/qat/qat_common/adf_common_drv.h
index 7836dff..6882c52 100644
--- a/drivers/crypto/qat/qat_common/adf_common_drv.h
+++ b/drivers/crypto/qat/qat_common/adf_common_drv.h
@@ -168,7 +168,7 @@ void qat_algs_exit(void);
 int qat_algs_register(void);
 int qat_algs_unregister(void);
 int qat_asym_algs_register(void);
-void qat_asym_algs_unregister(void);
+int qat_asym_algs_unregister(void);
 
 int qat_hal_init(struct adf_accel_dev *accel_dev);
 void qat_hal_deinit(struct icp_qat_fw_loader_handle *handle);
diff --git a/drivers/crypto/qat/qat_common/adf_init.c b/drivers/crypto/qat/qat_common/adf_init.c
index ac37a89..e9d52a8 100644
--- a/drivers/crypto/qat/qat_common/adf_init.c
+++ b/drivers/crypto/qat/qat_common/adf_init.c
@@ -272,13 +272,11 @@ int adf_dev_stop(struct adf_accel_dev *accel_dev)
 	clear_bit(ADF_STATUS_STARTING, &accel_dev->status);
 	clear_bit(ADF_STATUS_STARTED, &accel_dev->status);
 
-	if (!list_empty(&accel_dev->crypto_list) && qat_algs_unregister())
+	if (!list_empty(&accel_dev->crypto_list) &&
+	    (qat_algs_unregister() || qat_asym_algs_unregister()))
 		dev_err(&GET_DEV(accel_dev),
 			"Failed to unregister crypto algs\n");
 
-	if (!list_empty(&accel_dev->crypto_list))
-		qat_asym_algs_unregister();
-
 	list_for_each(list_itr, &service_table) {
 		service = list_entry(list_itr, struct service_hndl, list);
 		if (!test_bit(accel_dev->accel_id, &service->start_status))
diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c
index e87f510..7de765d 100644
--- a/drivers/crypto/qat/qat_common/qat_asym_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c
@@ -643,10 +643,13 @@ int qat_asym_algs_register(void)
 	return ret;
 }
 
-void qat_asym_algs_unregister(void)
+int qat_asym_algs_unregister(void)
 {
+	int ret = 0;
+
 	mutex_lock(&algs_lock);
 	if (--active_devs == 0)
-		crypto_unregister_akcipher(&rsa);
+		ret = crypto_unregister_akcipher(&rsa);
 	mutex_unlock(&algs_lock);
+	return ret;
 }

  parent reply	other threads:[~2015-09-09 16:17 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-09 16:14 [PATCH 0/8] crypto: Updates to akcipher API Tadeusz Struk
2015-09-09 16:15 ` [PATCH 1/8] crypto: akcipher - return status from crypto_unregister_alg Tadeusz Struk
2015-09-18 11:29   ` Herbert Xu
2015-09-09 16:15 ` [PATCH 2/8] crypto: rsa - check status returned from crypto_unregister_akcipher Tadeusz Struk
2015-09-09 16:15 ` Tadeusz Struk [this message]
2015-09-09 16:15 ` [PATCH 4/8] crypto: akcipher - Changes to asymmetric key API Tadeusz Struk
2015-09-09 16:25   ` Stephan Mueller
2015-09-09 16:29     ` Tadeusz Struk
2015-09-09 16:41       ` Stephan Mueller
2015-09-09 16:44         ` Tadeusz Struk
2015-09-09 18:53         ` Andrzej Zaborowski
2015-09-09 19:13           ` Stephan Mueller
2015-09-09 19:35             ` Tadeusz Struk
2015-09-18 11:35   ` Herbert Xu
2015-09-09 16:15 ` [PATCH 5/8] lib/scatterlist: Add sg_len helper Tadeusz Struk
2015-09-09 16:27   ` Stephan Mueller
2015-09-09 16:31     ` Tadeusz Struk
2015-09-09 16:39       ` Stephan Mueller
2015-09-09 16:46         ` Tadeusz Struk
2015-09-09 16:49           ` Stephan Mueller
2015-09-09 16:51             ` Tadeusz Struk
2015-09-09 16:56               ` Stephan Mueller
2015-09-09 17:02                 ` Tadeusz Struk
2015-09-09 17:05                   ` Stephan Mueller
2015-09-09 17:16                     ` Tadeusz Struk
2015-09-09 17:37                       ` Stephan Mueller
2015-09-09 16:54       ` Stephan Mueller
2015-09-09 16:15 ` [PATCH 6/8] crypto: rsa - update accoring to akcipher API changes Tadeusz Struk
2015-09-09 16:35   ` Stephan Mueller
2015-09-09 18:03     ` Tadeusz Struk
2015-09-09 16:15 ` [PATCH 7/8] crypto: qat " Tadeusz Struk
2015-09-09 16:15 ` [PATCH 8/8] crypto: testmgr - update test mgr according to " Tadeusz Struk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150909161513.2828.43757.stgit@tstruk-mobl1 \
    --to=tadeusz.struk@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=qat-linux@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox