* [PATCH] hw_random: octeon-rng: Use devm_hwrng_register
@ 2015-09-10 6:02 Vaishali Thakkar
2015-09-18 13:57 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Vaishali Thakkar @ 2015-09-10 6:02 UTC (permalink / raw)
To: Herbert Xu; +Cc: Matt Mackall, linux-crypto, linux-kernel
Use resource managed function devm_hwrng_register instead of
hwrng_register to make the error-path simpler. Also, remove
octeon_rng_remove as it is now redundant.
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
---
drivers/char/hw_random/octeon-rng.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/char/hw_random/octeon-rng.c b/drivers/char/hw_random/octeon-rng.c
index 6234a4a..8c78aa0 100644
--- a/drivers/char/hw_random/octeon-rng.c
+++ b/drivers/char/hw_random/octeon-rng.c
@@ -96,7 +96,7 @@ static int octeon_rng_probe(struct platform_device *pdev)
rng->ops = ops;
platform_set_drvdata(pdev, &rng->ops);
- ret = hwrng_register(&rng->ops);
+ ret = devm_hwrng_register(&pdev->dev, &rng->ops);
if (ret)
return -ENOENT;
@@ -105,21 +105,11 @@ static int octeon_rng_probe(struct platform_device *pdev)
return 0;
}
-static int octeon_rng_remove(struct platform_device *pdev)
-{
- struct hwrng *rng = platform_get_drvdata(pdev);
-
- hwrng_unregister(rng);
-
- return 0;
-}
-
static struct platform_driver octeon_rng_driver = {
.driver = {
.name = "octeon_rng",
},
.probe = octeon_rng_probe,
- .remove = octeon_rng_remove,
};
module_platform_driver(octeon_rng_driver);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw_random: octeon-rng: Use devm_hwrng_register
2015-09-10 6:02 [PATCH] hw_random: octeon-rng: Use devm_hwrng_register Vaishali Thakkar
@ 2015-09-18 13:57 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2015-09-18 13:57 UTC (permalink / raw)
To: Vaishali Thakkar; +Cc: Matt Mackall, linux-crypto, linux-kernel
On Thu, Sep 10, 2015 at 11:32:26AM +0530, Vaishali Thakkar wrote:
> Use resource managed function devm_hwrng_register instead of
> hwrng_register to make the error-path simpler. Also, remove
> octeon_rng_remove as it is now redundant.
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-18 13:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-10 6:02 [PATCH] hw_random: octeon-rng: Use devm_hwrng_register Vaishali Thakkar
2015-09-18 13:57 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).