From: LABBE Corentin <clabbe.montjoie@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Tony Battersby <tonyb@cybernetics.com>,
davem@davemloft.net, akpm@linux-foundation.org, arnd@arndb.de,
axboe@fb.com, david.s.gordon@intel.com,
martin.petersen@oracle.com, robert.jarzmik@free.fr,
thomas.lendacky@amd.com, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, lee.nipper@gmail.com,
yuan.j.kang@gmail.com
Subject: Re: [PATCH v2 5/8] lib: introduce sg_nents_len_chained
Date: Mon, 21 Sep 2015 16:59:55 +0200 [thread overview]
Message-ID: <20150921145955.GA20784@Red> (raw)
In-Reply-To: <20150921141917.GA2278@gondor.apana.org.au>
On Mon, Sep 21, 2015 at 10:19:17PM +0800, Herbert Xu wrote:
> On Fri, Sep 18, 2015 at 05:25:47PM -0400, Tony Battersby wrote:
> >
> > So instead of adding a new function sg_nents_len_chained(), a better
> > cleanup would be:
> > 1) replace the driver-specific functions with calls to sg_nents_for_len()
> > 2) get rid of the "chained" variables
> > 3) always call dma_map_sg()/dma_unmap_sg() for the entire scatterlist
> > regardless of whether or not the scatterlist is chained
> >
> > Would someone more familiar with the crypto API please confirm that my
> > suggestions are correct?
>
> Yes I think you're absolutely right Tony. Corentin, could you
> please take this opportunity to clean up those drivers so that
> they simply use dma_map_sg a single time rather than over and
> over again for chained SG lists?
Yes I will
>
> You only have to redo patches 5-8.
>
> Thanks,
next prev parent reply other threads:[~2015-09-21 15:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 12:57 [PATCH v2] crypto: Remove duplicate code of SG helpers functions LABBE Corentin
2015-09-18 12:57 ` [PATCH v2 1/8] crypto: bfin: replace sg_count by sg_nents LABBE Corentin
2015-09-18 12:57 ` [PATCH v2 2/8] crypto: amcc replace get_sg_count by sg_nents_for_len LABBE Corentin
2015-09-18 12:57 ` [PATCH v2 3/8] crypto: sahara: replace sahara_sg_length with sg_nents_for_len LABBE Corentin
2015-09-18 12:57 ` [PATCH v2 4/8] s390: replace zfcp_qdio_sbale_count by sg_nents LABBE Corentin
2015-09-30 13:59 ` Steffen Maier
2015-09-18 12:57 ` [PATCH v2 5/8] lib: introduce sg_nents_len_chained LABBE Corentin
2015-09-18 14:01 ` Tom Lendacky
2015-09-18 16:19 ` Tony Battersby
2015-09-18 21:25 ` Tony Battersby
2015-09-21 14:19 ` Herbert Xu
2015-09-21 14:59 ` LABBE Corentin [this message]
2015-09-18 12:57 ` [PATCH v2 6/8] crypto: talitos: replace sg_count with sg_nents_len_chained LABBE Corentin
2015-09-18 12:57 ` [PATCH v2 7/8] crypto: qce: replace qce_countsg " LABBE Corentin
2015-09-18 12:57 ` [PATCH v2 8/8] crypto: caam: replace __sg_count " LABBE Corentin
2015-09-21 15:09 ` [PATCH v2] crypto: Remove duplicate code of SG helpers functions Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921145955.GA20784@Red \
--to=clabbe.montjoie@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@fb.com \
--cc=davem@davemloft.net \
--cc=david.s.gordon@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=lee.nipper@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=robert.jarzmik@free.fr \
--cc=thomas.lendacky@amd.com \
--cc=tonyb@cybernetics.com \
--cc=yuan.j.kang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).