From: Herbert Xu <herbert@gondor.apana.org.au>
To: Andrzej Zaborowski <andrew.zaborowski@intel.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH v5 3/4] crypto: akcipher: add akcipher declarations needed by templates.
Date: Sat, 28 Nov 2015 15:10:35 +0800 [thread overview]
Message-ID: <20151128071035.GA4474@gondor.apana.org.au> (raw)
In-Reply-To: <CAOq732K-A3-ypsLavOJrT_ENuSM=zuriJo0F5bS1dNuhbeRTDA@mail.gmail.com>
On Fri, Nov 27, 2015 at 04:10:41PM +0100, Andrzej Zaborowski wrote:
>
> You're right there aren't any users that need this now but again is
> there any reason you prefer the inst->free approach?
Because this method is type-safe while the old way is not.
> BTW note the lines that assign inst->free in crypto/gcm.c end with
> commas which could lead to confusion.
Please send a patch.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2015-11-28 7:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 21:53 [PATCH v5 3/4] crypto: akcipher: add akcipher declarations needed by templates Andrew Zaborowski
2015-11-26 21:53 ` [PATCH v5 4/4] crypto: RSA padding algorithm Andrew Zaborowski
2015-11-27 13:17 ` Herbert Xu
2015-11-27 13:12 ` [PATCH v5 3/4] crypto: akcipher: add akcipher declarations needed by templates Herbert Xu
2015-11-27 15:10 ` Andrzej Zaborowski
2015-11-28 7:10 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151128071035.GA4474@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=andrew.zaborowski@intel.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox