Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	Zain Wang <zain.wang@rock-chips.com>,
	linux-crypto@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] crypto: rockchip/crypto - fix possible deadlock
Date: Sat, 28 Nov 2015 16:57:08 +0800	[thread overview]
Message-ID: <20151128085708.GA5372@gondor.apana.org.au> (raw)
In-Reply-To: <2330117.Be8JzFqibx@diego>

On Sat, Nov 28, 2015 at 01:48:53AM +0100, Heiko Stübner wrote:
>
> @@ -169,9 +169,10 @@ static irqreturn_t rk_crypto_irq_handle(int irq, void *dev_id)
>  {
>  	struct rk_crypto_info *dev  = platform_get_drvdata(dev_id);
>  	u32 interrupt_status;
> +	unsigned long flags;
>  	int err = 0;
>  
> -	spin_lock(&dev->lock);
> +	spin_lock_irqsave(&dev->lock, flags);

You don't need to disable IRQs in an IRQ handler.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

      reply	other threads:[~2015-11-28  8:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-28  0:48 [PATCH] crypto: rockchip/crypto - fix possible deadlock Heiko Stübner
2015-11-28  8:57 ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151128085708.GA5372@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=heiko@sntech.de \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=zain.wang@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox