From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] crypto: qat - fix some timeout tests Date: Tue, 15 Dec 2015 13:05:15 +0300 Message-ID: <20151215100515.GB20848@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Herbert Xu , "David S. Miller" , Bruce Allan , Pingchao Yang , qat-linux@intel.com, linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org To: Tadeusz Struk Return-path: Content-Disposition: inline Sender: kernel-janitors-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org We do an "if (!times)" test later to see if we ran the loop too many times, but because it is a postop negate that means times is -1 when we exit that way. I have fixed this by changing it from a post op to a preop. Fixes: b3416fb8a2f5 ('crypto: qat - Intel(R) QAT accelengine part of fw loader') Signed-off-by: Dan Carpenter --- This means we only loop 9999 times instead of 10000 like before but I figure it probably doesn't matter. diff --git a/drivers/crypto/qat/qat_common/qat_hal.c b/drivers/crypto/qat/qat_common/qat_hal.c index 45c1739..2b078a6 100644 --- a/drivers/crypto/qat/qat_common/qat_hal.c +++ b/drivers/crypto/qat/qat_common/qat_hal.c @@ -171,7 +171,7 @@ static int qat_hal_wait_cycles(struct icp_qat_fw_loader_handle *handle, qat_hal_rd_ae_csr(handle, ae, PROFILE_COUNT, &base_cnt); base_cnt &= 0xffff; - while ((int)cycles > elapsed_cycles && times--) { + while ((int)cycles > elapsed_cycles && --times) { if (chk_inactive) qat_hal_rd_ae_csr(handle, ae, ACTIVE_CTX_STATUS, &csr);