From: Jean Delvare <jdelvare@suse.de>
To: linux-crypto@vger.kernel.org
Cc: Tim Chen <tim.c.chen@linux.intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Michal Marek <mmarek@suse.cz>
Subject: [PATCH] crypto: Fix crc32c soft dependency
Date: Mon, 18 Jan 2016 17:06:05 +0100 [thread overview]
Message-ID: <20160118170605.4e4a022f@endymion.delvare> (raw)
I don't think it makes sense for a module to have a soft dependency
on itself. This seems quite cyclic by nature and I can't see what
purpose it could serve.
OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty
much assumes that some incarnation of the "crc32c" hash algorithm has
been loaded. Therefore it makes sense to have the soft dependency
there (as crc-t10dif does.)
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
---
crypto/crc32c_generic.c | 1 -
lib/libcrc32c.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
--- linux-4.5-rc0.orig/crypto/crc32c_generic.c 2016-01-11 00:01:32.000000000 +0100
+++ linux-4.5-rc0/crypto/crc32c_generic.c 2016-01-18 16:47:35.243398451 +0100
@@ -172,4 +172,3 @@ MODULE_DESCRIPTION("CRC32c (Castagnoli)
MODULE_LICENSE("GPL");
MODULE_ALIAS_CRYPTO("crc32c");
MODULE_ALIAS_CRYPTO("crc32c-generic");
-MODULE_SOFTDEP("pre: crc32c");
--- linux-4.5-rc0.orig/lib/libcrc32c.c 2016-01-11 00:01:32.000000000 +0100
+++ linux-4.5-rc0/lib/libcrc32c.c 2016-01-18 16:47:47.978681236 +0100
@@ -74,3 +74,4 @@ module_exit(libcrc32c_mod_fini);
MODULE_AUTHOR("Clay Haapala <chaapala@cisco.com>");
MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations");
MODULE_LICENSE("GPL");
+MODULE_SOFTDEP("pre: crc32c");
--
Jean Delvare
SUSE L3 Support
next reply other threads:[~2016-01-18 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 16:06 Jean Delvare [this message]
2016-01-19 7:57 ` [PATCH] crypto: Fix crc32c soft dependency Herbert Xu
2016-01-19 21:13 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160118170605.4e4a022f@endymion.delvare \
--to=jdelvare@suse.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).