From: Herbert Xu <herbert@gondor.apana.org.au>
To: Raj Ammanur <rammanur@arista.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: aesni-intel - avoid IPsec re-ordering
Date: Wed, 20 Jan 2016 11:25:37 +0800 [thread overview]
Message-ID: <20160120032537.GA18992@gondor.apana.org.au> (raw)
In-Reply-To: <CAMFBXfkgjTtBX4sePTr30WenzDgw=h0yp8fp17de=ao+8AT=Mg@mail.gmail.com>
On Tue, Jan 19, 2016 at 09:39:51AM -0800, Raj Ammanur wrote:
> Thanks a bunch Herbert. I will try out the patch when you make it available.
>
>
> Are there any thoughts for these other questions from you or anyone
> else on the list, more
> importantly regarding backlog handling in ESP ?
>
>
> 2. When the pkts are put on the async work queue, the queue size is initialized
> as 100 in cryptd_init_queue() in crypto/cryptd.c. Does anyone know how/why
> 100 was picked ?
This should probably be increased to match NAPI queue lengths.
> 3. In cryptd_queue_worker(), the backlog->complete() callback is invoked with
> -EINPROGRESS. In net/ipv4/esp4.c, there is no handling for EINPROGRESS
> in esp_input_done()/esp_input_done2(). Am I reading the code correctly and
> is there any expectation that ESP should support backlog and have backlog
> handling ? Currently, the pkt just gets dropped as the EINPROGRESS is treated
> as nexthdr and hence is invalid.
IPsec does not use crypto backlogging so complete should never be
called with EINPROGRESS. If the queue length is exceeded the
packet will be dropped.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-01-20 3:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 7:26 [PATCH] crypto: aesni-intel - avoid IPsec re-ordering Raj Ammanur
2016-01-19 7:43 ` Herbert Xu
2016-01-19 17:39 ` Raj Ammanur
2016-01-20 3:25 ` Herbert Xu [this message]
2016-01-20 8:31 ` Raj Ammanur
2016-01-20 8:38 ` Herbert Xu
2016-01-20 17:30 ` Raj Ammanur
-- strict thread matches above, loose matches on Subject: below --
2014-11-12 5:49 Ming Liu
2014-11-12 8:41 ` Steffen Klassert
2014-11-12 8:51 ` Herbert Xu
2014-11-12 9:12 ` Steffen Klassert
2014-11-12 10:41 ` Ming Liu
2014-11-12 11:43 ` Steffen Klassert
2014-11-13 1:52 ` Ming Liu
2014-11-12 10:41 ` Ming Liu
2014-11-12 11:48 ` Steffen Klassert
2014-11-13 1:53 ` Ming Liu
2014-11-15 3:15 ` Herbert Xu
2014-11-20 7:26 ` Steffen Klassert
2014-11-20 7:43 ` Herbert Xu
2014-11-20 7:59 ` Steffen Klassert
2014-11-20 8:02 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160120032537.GA18992@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=rammanur@arista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).