From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "Li, Weigang" <weigang.li@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Minchan Kim <minchan@kernel.org>,
Dan Streetman <ddstreet@ieee.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support
Date: Mon, 1 Feb 2016 11:11:42 +0900 [thread overview]
Message-ID: <20160201021141.GA32125@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <20160129100901.GA17272@gondor.apana.org.au>
On Fri, Jan 29, 2016 at 06:09:01PM +0800, Herbert Xu wrote:
> On Thu, Jan 28, 2016 at 12:19:42PM +0900, Joonsoo Kim wrote:
> >
> > I have tested asynchronous compression APIs in zram and I saw
> > regression. Atomic allocation and setting up SG lists are culprit
> > for this regression. Moreover, zram optimizes linearisation
>
> So which is it, atomic allocations or setting up SG lists? There
> is nothing in acomp that requires you to do an atomic allocation.
Atomic allocation are called for linearisation when needed. Zram's
compressed content is usually stored in two physically separate pages
so linearisation is needed. See scomp_map().
Setting up SG lists means that to use acomp, sg_init_table(),
sg_set_page() are need to be called by zram unlike the case just
passing the pointer based buffer.
Thanks.
next prev parent reply other threads:[~2016-02-01 2:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 8:15 [PATCH v2 00/10] Introduce new async/sync compression APIs Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 01/10] crypto/compress: remove unused pcomp interface Joonsoo Kim
2016-01-27 14:17 ` Herbert Xu
2016-01-26 8:15 ` [PATCH v2 02/10] crypto: add algorithm type specific flag, CRYPTO_ALG_PRIVATE Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 03/10] crypto/compress: introduce sychronuous compression API Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 04/10] crypto/compress: add asynchronous compression support Joonsoo Kim
2016-01-27 7:41 ` Herbert Xu
2016-01-27 7:59 ` Li, Weigang
2016-01-27 8:03 ` Herbert Xu
2016-01-27 8:09 ` Herbert Xu
2016-01-27 8:26 ` Li, Weigang
2016-01-28 3:19 ` Joonsoo Kim
2016-01-29 10:09 ` Herbert Xu
2016-02-01 2:11 ` Joonsoo Kim [this message]
2016-02-04 3:25 ` Li, Weigang
2016-02-04 3:28 ` Herbert Xu
2016-02-04 3:29 ` Herbert Xu
2016-02-04 3:50 ` Li, Weigang
2016-02-04 14:56 ` Herbert Xu
2016-02-04 7:17 ` Joonsoo Kim
2016-02-04 14:53 ` Herbert Xu
2016-02-04 16:19 ` Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 05/10] crypto/lzo: support new compression APIs Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 06/10] crypto/lz4: " Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 07/10] crypto/lz4hc: " Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 08/10] crypto/842: " Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 09/10] crypto/deflate: " Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 10/10] crypto/testmgr: add new compression APIs test Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201021141.GA32125@js1304-P5Q-DELUXE \
--to=iamjoonsoo.kim@lge.com \
--cc=davem@davemloft.net \
--cc=ddstreet@ieee.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=weigang.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox