* [patch] crypto: rsa-pkcs1pad: indent a couple statements
@ 2016-03-08 12:07 Dan Carpenter
2016-03-11 13:21 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-03-08 12:07 UTC (permalink / raw)
To: Herbert Xu, Tadeusz Struk; +Cc: David S. Miller, linux-crypto, kernel-janitors
These if statements aren't indented far enough and it makes static
checkers complain.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Hopefully GCC6 will start complaining about these as well?
diff --git a/crypto/rsa-pkcs1pad.c b/crypto/rsa-pkcs1pad.c
index 1cea67d..1eb5cbe 100644
--- a/crypto/rsa-pkcs1pad.c
+++ b/crypto/rsa-pkcs1pad.c
@@ -705,7 +705,7 @@ static int pkcs1pad_create(struct crypto_template *tmpl, struct rtattr **tb)
CRYPTO_MAX_ALG_NAME, "pkcs1pad(%s)",
rsa_alg->base.cra_driver_name) >=
CRYPTO_MAX_ALG_NAME)
- goto out_drop_alg;
+ goto out_drop_alg;
} else {
if (snprintf(inst->alg.base.cra_name,
CRYPTO_MAX_ALG_NAME, "pkcs1pad(%s,%s)",
@@ -715,7 +715,7 @@ static int pkcs1pad_create(struct crypto_template *tmpl, struct rtattr **tb)
CRYPTO_MAX_ALG_NAME, "pkcs1pad(%s,%s)",
rsa_alg->base.cra_driver_name, hash_name) >=
CRYPTO_MAX_ALG_NAME)
- goto out_free_hash;
+ goto out_free_hash;
}
inst->alg.base.cra_flags = rsa_alg->base.cra_flags & CRYPTO_ALG_ASYNC;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] crypto: rsa-pkcs1pad: indent a couple statements
2016-03-08 12:07 [patch] crypto: rsa-pkcs1pad: indent a couple statements Dan Carpenter
@ 2016-03-11 13:21 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2016-03-11 13:21 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tadeusz Struk, David S. Miller, linux-crypto, kernel-janitors
On Tue, Mar 08, 2016 at 03:07:36PM +0300, Dan Carpenter wrote:
> These if statements aren't indented far enough and it makes static
> checkers complain.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Sorry but this doesn't apply against cryptodev.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-11 13:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-08 12:07 [patch] crypto: rsa-pkcs1pad: indent a couple statements Dan Carpenter
2016-03-11 13:21 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).