From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <gregkh@linuxfoundation.org>,
stable@vger.kernel.org,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Jussi Kivilinna <jussi.kivilinna@iki.fi>,
patrick.meyer@vasgard.com
Subject: Re: [PATCH] crypto: gcm - Fix rfc4543 decryption crash
Date: Wed, 27 Apr 2016 12:17:44 +0800 [thread overview]
Message-ID: <20160427041744.GA27044@gondor.apana.org.au> (raw)
In-Reply-To: <1461670976.14569.40.camel@decadent.org.uk>
On Tue, Apr 26, 2016 at 01:42:56PM +0200, Ben Hutchings wrote:
>
> It looks like the bug was introduced in 3.10 by:
>
> d733ac90f9fe8ac284e523f9920b507555b12f6d
> Author: Jussi Kivilinna <jussi.kivilinna@iki.fi>
> Date: Sun Apr 7 16:43:46 2013 +0300
>
> crypto: gcm - fix rfc4543 to handle async crypto correctly
>
> So 3.2.y and 3.4.y don't need this fix - or should they get both fixes?
If that patch is not present then my fix can't be applied. However,
I think this change itself is probably needed in 3.2/3.4 as otherwise
GCM would be broken if the underlying cipher is async. It's not a
big deal on x86 because the main async AES provider also provides
GCM directly, but on other architectures it may be an issue.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-04-27 4:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 14:42 [PATCH] crypto: gcm - Fix rfc4543 decryption crash Herbert Xu
2016-03-18 17:34 ` Greg KH
2016-03-19 2:23 ` Herbert Xu
2016-04-26 11:42 ` Ben Hutchings
2016-04-27 4:17 ` Herbert Xu [this message]
2016-05-15 19:48 ` Ben Hutchings
2016-04-26 21:05 ` Ben Hutchings
2016-05-01 22:59 ` Patch "crypto: gcm - Fix rfc4543 decryption crash" has been added to the 3.14-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427041744.GA27044@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ben@decadent.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jussi.kivilinna@iki.fi \
--cc=linux-crypto@vger.kernel.org \
--cc=patrick.meyer@vasgard.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox