From: Dan Carpenter <dan.carpenter@oracle.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] crypto: omap-sham - potential Oops on error in probe
Date: Wed, 18 May 2016 14:44:43 +0300 [thread overview]
Message-ID: <20160518114443.GG11011@mwanda> (raw)
In-Reply-To: <21712178-666f-e2e2-24f3-fb0c513acc83@ti.com>
On Wed, May 18, 2016 at 01:42:36PM +0300, Peter Ujfalusi wrote:
> On 05/18/16 13:39, Dan Carpenter wrote:
> > This if statement is reversed so we end up either leaking or Oopsing on
> > error.
>
> Oops, sorry for that.
> Probably the other omap-* crypto drivers have the same issue? Can you send a
> patch for them or should I do it?
I didn't see those static checker warnings so probably it means I can't
compile the drivers. Could you do it?
regards,
dan carpenter
next prev parent reply other threads:[~2016-05-18 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 10:39 [patch] crypto: omap-sham - potential Oops on error in probe Dan Carpenter
2016-05-18 10:42 ` Peter Ujfalusi
2016-05-18 11:44 ` Dan Carpenter [this message]
2016-05-18 11:50 ` Peter Ujfalusi
2016-05-19 10:07 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160518114443.GG11011@mwanda \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox