From: Herbert Xu <herbert@gondor.apana.org.au>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH v4 02/10] crypto: add asynchronous compression api
Date: Thu, 2 Jun 2016 17:12:19 +0800 [thread overview]
Message-ID: <20160602091219.GC15919@gondor.apana.org.au> (raw)
In-Reply-To: <1464702936-27627-3-git-send-email-giovanni.cabiddu@intel.com>
On Tue, May 31, 2016 at 02:55:28PM +0100, Giovanni Cabiddu wrote:
>
> +/**
> + * struct acomp_req - asynchronous (de)compression request
> + *
> + * @base: Common attributes for asynchronous crypto requests
> + * @src: Source Data
> + * @dst: Destination data
> + * @slen: Size of the input buffer
> + * @dlen: Size of the output buffer
> + * @consumed: Number of bytes consumed by the (de)compressor
> + * @produced: Number of bytes produced by the (de)compressor
Why do we need these two? For a moment I thought you were going
to add pcomp again :)
Since we're only support compression in one go, the number of
bytes consumed must be equal to slen unless there was an error.
For the number of bytes produced I'd prefer to just use dlen for it.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-06-02 9:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 13:55 [PATCH v4 00/10] crypto: asynchronous compression api Giovanni Cabiddu
2016-05-31 13:55 ` [PATCH v4 01/10] crypto: shrink hash down to two types Giovanni Cabiddu
2016-05-31 13:55 ` [PATCH v4 02/10] crypto: add asynchronous compression api Giovanni Cabiddu
2016-06-02 9:12 ` Herbert Xu [this message]
2016-05-31 13:55 ` [PATCH v4 03/10] crypto: add driver-side scomp interface Giovanni Cabiddu
2016-05-31 13:55 ` [PATCH v4 04/10] crypto: add quick decompression api Giovanni Cabiddu
2016-06-02 9:15 ` Herbert Xu
2016-05-31 13:55 ` [PATCH v4 05/10] crypto: acomp - add support for lzo via scomp Giovanni Cabiddu
2016-05-31 13:55 ` [PATCH v4 06/10] crypto: acomp - add support for lz4 " Giovanni Cabiddu
2016-05-31 13:55 ` [PATCH v4 07/10] crypto: acomp - add support for lz4hc " Giovanni Cabiddu
2016-05-31 13:55 ` [PATCH v4 08/10] crypto: acomp - add support for 842 " Giovanni Cabiddu
2016-05-31 13:55 ` [PATCH v4 09/10] crypto: acomp - add support for deflate " Giovanni Cabiddu
2016-05-31 13:55 ` [PATCH v4 10/10] crypto: acomp - update testmgr with support for acomp Giovanni Cabiddu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602091219.GC15919@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=giovanni.cabiddu@intel.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox