From: Herbert Xu <herbert@gondor.apana.org.au>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH v5 3/9] crypto: add driver-side scomp interface
Date: Tue, 7 Jun 2016 18:22:09 +0800 [thread overview]
Message-ID: <20160607102209.GA32725@gondor.apana.org.au> (raw)
In-Reply-To: <1464870543-5988-4-git-send-email-giovanni.cabiddu@intel.com>
On Thu, Jun 02, 2016 at 01:28:57PM +0100, Giovanni Cabiddu wrote:
>
> @@ -96,6 +116,31 @@ struct crypto_acomp *crypto_alloc_acomp(const char *alg_name, u32 type,
> }
> EXPORT_SYMBOL_GPL(crypto_alloc_acomp);
>
> +struct acomp_req *acomp_request_alloc(struct crypto_acomp *acomp, gfp_t gfp)
> +{
> + struct crypto_tfm *tfm = crypto_acomp_tfm(acomp);
> + struct acomp_req *req;
> +
> + req = __acomp_request_alloc(acomp, gfp);
> + if (req && (tfm->__crt_alg->cra_type != &crypto_acomp_type))
> + return crypto_acomp_scomp_alloc_ctx(req);
The gfp argument is pointless since scomp requires GFP_KERNEL.
So please just make it a requirement that acomp_request_alloc
always uses GFP_KERNEL.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-06-07 10:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 12:28 [PATCH v5 0/9] crypto: asynchronous compression api Giovanni Cabiddu
2016-06-02 12:28 ` [PATCH v5 1/9] crypto: shrink hash down to two types Giovanni Cabiddu
2016-06-07 10:52 ` Herbert Xu
2016-06-02 12:28 ` [PATCH v5 2/9] crypto: add asynchronous compression api Giovanni Cabiddu
2016-06-02 12:28 ` [PATCH v5 3/9] crypto: add driver-side scomp interface Giovanni Cabiddu
2016-06-07 10:22 ` Herbert Xu [this message]
2016-06-02 12:28 ` [PATCH v5 4/9] crypto: acomp - add support for lzo via scomp Giovanni Cabiddu
2016-06-02 12:28 ` [PATCH v5 5/9] crypto: acomp - add support for lz4 " Giovanni Cabiddu
2016-06-02 12:29 ` [PATCH v5 6/9] crypto: acomp - add support for lz4hc " Giovanni Cabiddu
2016-06-02 12:29 ` [PATCH v5 7/9] crypto: acomp - add support for 842 " Giovanni Cabiddu
2016-06-02 12:29 ` [PATCH v5 8/9] crypto: acomp - add support for deflate " Giovanni Cabiddu
2016-06-02 12:29 ` [PATCH v5 9/9] crypto: acomp - update testmgr with support for acomp Giovanni Cabiddu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607102209.GA32725@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=giovanni.cabiddu@intel.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox