Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tudor Ambarus <tudor-dan.ambarus@nxp.com>
Cc: linux-crypto@vger.kernel.org, horia.geanta@nxp.com
Subject: Re: [PATCH v8 1/3] crypto: scatterwak - Add scatterwalk_sg_copychunks
Date: Mon, 20 Jun 2016 18:54:49 +0800	[thread overview]
Message-ID: <20160620105449.GA10464@gondor.apana.org.au> (raw)
In-Reply-To: <1466002364-16945-2-git-send-email-tudor-dan.ambarus@nxp.com>

On Wed, Jun 15, 2016 at 05:52:42PM +0300, Tudor Ambarus wrote:
> This patch adds the function scatterwalk_sg_copychunks which writes
> a chunk of data from a scatterwalk to another scatterwalk.
> It will be used by caam driver to remove the leading zeros
> for the output data of the RSA algorithm, after the computation completes.
> 
> Signed-off-by: Tudor Ambarus <tudor-dan.ambarus@nxp.com>

Not only does dropping leading zeroes lead to questions about
information leaks, but it makes every one of our RSA drivers
look crap.

So I'm going to change this and make it not skip leading zeroes.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2016-06-20 10:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15 14:52 [PATCH v8 0/3] crypto: caam - add support for RSA algorithm Tudor Ambarus
2016-06-15 14:52 ` [PATCH v8 1/3] crypto: scatterwak - Add scatterwalk_sg_copychunks Tudor Ambarus
2016-06-20 10:54   ` Herbert Xu [this message]
2016-06-15 14:52 ` [PATCH v8 2/3] crypto: scatterwalk - export scatterwalk_pagedone Tudor Ambarus
2016-06-15 14:52 ` [PATCH v8 3/3] crypto: caam - add support for RSA algorithm Tudor Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160620105449.GA10464@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=tudor-dan.ambarus@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox