From: Herbert Xu <herbert@gondor.apana.org.au>
To: Salvatore Benedetto <salvatore.benedetto@intel.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH v9 2/3] crypto: kpp - Add DH software implementation
Date: Mon, 20 Jun 2016 19:13:11 +0800 [thread overview]
Message-ID: <20160620111310.GA10601@gondor.apana.org.au> (raw)
In-Reply-To: <1466174265-4546-3-git-send-email-salvatore.benedetto@intel.com>
On Fri, Jun 17, 2016 at 03:37:44PM +0100, Salvatore Benedetto wrote:
>
> +int crypto_dh_encode_key(char *buf, unsigned int len, const struct dh *params)
> +{
> + struct kpp_secret *secret = (struct kpp_secret *)buf;
You can't do that. The memory under buf may not be aligned so
you need to copy it.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-06-20 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 14:37 [PATCH v9 0/3] Key-agreement Protocol Primitives (KPP) API Salvatore Benedetto
2016-06-17 14:37 ` [PATCH v9 1/3] crypto: Key-agreement Protocol Primitives API (KPP) Salvatore Benedetto
2016-06-17 14:37 ` [PATCH v9 2/3] crypto: kpp - Add DH software implementation Salvatore Benedetto
2016-06-20 11:13 ` Herbert Xu [this message]
2016-06-20 11:44 ` Benedetto, Salvatore
2016-06-20 11:15 ` Herbert Xu
2016-06-20 11:43 ` Benedetto, Salvatore
2016-06-20 23:49 ` Herbert Xu
2016-06-21 20:57 ` Benedetto, Salvatore
2016-06-17 14:37 ` [PATCH v9 3/3] crypto: kpp - Add ECDH software support Salvatore Benedetto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620111310.GA10601@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=salvatore.benedetto@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox