From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Benedetto, Salvatore" <salvatore.benedetto@intel.com>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH v10 2/3] crypto: kpp - Add DH software implementation
Date: Wed, 22 Jun 2016 14:40:47 +0800 [thread overview]
Message-ID: <20160622064047.GA29318@gondor.apana.org.au> (raw)
In-Reply-To: <309B30E91F5E2846B79BD9AA9711D03193664C@IRSMSX102.ger.corp.intel.com>
On Wed, Jun 22, 2016 at 06:37:50AM +0000, Benedetto, Salvatore wrote:
>
> Can you explain me the benefit in doing so?
The less code we have the better. Most of our algorithm types
have a single test function, I have seen no reason why kpp should
be different.
akcipher has been an anomaly and I'm fixing it right now.
> I thought my patchset had reached an 'acceptable' state by now :-)
Now that the secret is encoded to a format under our control, you
can generate byte-stream test vectors for both DH and ECDH using the
same format. So there is no need to have test functions specific to
one algorithm.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-06-22 6:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 20:45 [PATCH v10 0/3] Key-agreement Protocol Primitives (KPP) API Salvatore Benedetto
2016-06-21 20:45 ` [PATCH v10 1/3] crypto: Key-agreement Protocol Primitives API (KPP) Salvatore Benedetto
2016-06-21 20:45 ` [PATCH v10 2/3] crypto: kpp - Add DH software implementation Salvatore Benedetto
2016-06-22 0:51 ` Herbert Xu
2016-06-22 6:37 ` Benedetto, Salvatore
2016-06-22 6:40 ` Herbert Xu [this message]
2016-06-22 8:18 ` Benedetto, Salvatore
2016-06-22 10:03 ` Herbert Xu
2016-06-22 10:06 ` Benedetto, Salvatore
2016-06-22 10:08 ` Herbert Xu
2016-06-21 20:45 ` [PATCH v10 3/3] crypto: kpp - Add ECDH software support Salvatore Benedetto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622064047.GA29318@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=salvatore.benedetto@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox