[cryptodev:master 84/87] security/keys/big_key.c:118:1: warning: 'big_key_crypt' uses dynamic stack allocation

[kbuild test robot <fengguang.wu@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3014 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head:   8f44df154de79a61b0e86734f51737b8cccf8dfe
commit: d56d72c6a0612be14ccb455c92886d2cb102c2ab [84/87] KEYS: Use skcipher for big keys
config: s390-allyesconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout d56d72c6a0612be14ccb455c92886d2cb102c2ab
        # save the attached .config to linux build tree
        make.cross ARCH=s390 

All warnings (new ones prefixed by >>):

   security/keys/big_key.c: In function 'big_key_crypt':
>> security/keys/big_key.c:118:1: warning: 'big_key_crypt' uses dynamic stack allocation
    }
    ^

vim +/big_key_crypt +118 security/keys/big_key.c

d56d72c6 Herbert Xu         2016-06-22  102  	skcipher_request_set_tfm(req, big_key_skcipher);
d56d72c6 Herbert Xu         2016-06-22  103  	skcipher_request_set_callback(req, CRYPTO_TFM_REQ_MAY_SLEEP,
d56d72c6 Herbert Xu         2016-06-22  104  				      NULL, NULL);
13100a72 Kirill Marinushkin 2016-04-12  105  
13100a72 Kirill Marinushkin 2016-04-12  106  	sg_init_one(&sgio, data, datalen);
d56d72c6 Herbert Xu         2016-06-22  107  	skcipher_request_set_crypt(req, &sgio, &sgio, datalen, NULL);
13100a72 Kirill Marinushkin 2016-04-12  108  
13100a72 Kirill Marinushkin 2016-04-12  109  	if (op == BIG_KEY_ENC)
d56d72c6 Herbert Xu         2016-06-22  110  		ret = crypto_skcipher_encrypt(req);
13100a72 Kirill Marinushkin 2016-04-12  111  	else
d56d72c6 Herbert Xu         2016-06-22  112  		ret = crypto_skcipher_decrypt(req);
d56d72c6 Herbert Xu         2016-06-22  113  
d56d72c6 Herbert Xu         2016-06-22  114  	skcipher_request_zero(req);
13100a72 Kirill Marinushkin 2016-04-12  115  
13100a72 Kirill Marinushkin 2016-04-12  116  error:
13100a72 Kirill Marinushkin 2016-04-12  117  	return ret;
13100a72 Kirill Marinushkin 2016-04-12 @118  }
13100a72 Kirill Marinushkin 2016-04-12  119  
13100a72 Kirill Marinushkin 2016-04-12  120  /*
002edaf7 David Howells      2014-07-18  121   * Preparse a big key
ab3c3587 David Howells      2013-09-24  122   */
002edaf7 David Howells      2014-07-18  123  int big_key_preparse(struct key_preparsed_payload *prep)
ab3c3587 David Howells      2013-09-24  124  {
146aa8b1 David Howells      2015-10-21  125  	struct path *path = (struct path *)&prep->payload.data[big_key_path];
ab3c3587 David Howells      2013-09-24  126  	struct file *file;

:::::: The code at line 118 was first introduced by commit
:::::: 13100a72f40f5748a04017e0ab3df4cf27c809ef Security: Keys: Big keys stored encrypted

:::::: TO: Kirill Marinushkin <k.marinushkin@gmail.com>
:::::: CC: David Howells <dhowells@redhat.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 41745 bytes --]