From: Herbert Xu <herbert@gondor.apana.org.au>
To: Salvatore Benedetto <salvatore.benedetto@intel.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: qat - Switch to new rsa_helper functions
Date: Fri, 1 Jul 2016 18:08:50 +0800 [thread overview]
Message-ID: <20160701100850.GA13758@gondor.apana.org.au> (raw)
In-Reply-To: <1467305947-4666-1-git-send-email-salvatore.benedetto@intel.com>
On Thu, Jun 30, 2016 at 05:59:07PM +0100, Salvatore Benedetto wrote:
> Drop all asn1 related code in qat and use the new rsa_helper
> functions rsa_parse_[pub|priv]_key for parsing the key
>
> Signed-off-by: Salvatore Benedetto <salvatore.benedetto@intel.com>
> ---
> crypto/testmgr.c | 1 +
> drivers/crypto/qat/Kconfig | 2 +-
> drivers/crypto/qat/qat_common/Makefile | 10 -----
> drivers/crypto/qat/qat_common/qat_asym_algs.c | 49 +++++++++--------------
> drivers/crypto/qat/qat_common/qat_rsaprivkey.asn1 | 11 -----
> drivers/crypto/qat/qat_common/qat_rsapubkey.asn1 | 4 --
> 6 files changed, 22 insertions(+), 55 deletions(-)
> delete mode 100644 drivers/crypto/qat/qat_common/qat_rsaprivkey.asn1
> delete mode 100644 drivers/crypto/qat/qat_common/qat_rsapubkey.asn1
>
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c
> index 537fdc3..b52a81c 100644
> --- a/crypto/testmgr.c
> +++ b/crypto/testmgr.c
> @@ -1941,6 +1941,7 @@ static int do_test_rsa(struct crypto_akcipher *tfm,
> if (err)
> goto free_req;
>
> + err = -ENOMEM;
> out_len_max = crypto_akcipher_maxsize(tfm);
> outbuf_enc = kzalloc(out_len_max, GFP_KERNEL);
> if (!outbuf_enc)
This should go into a separate patch. Please also rebase it on
my RSA patch series and do_test_rsa no longer exists.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2016-07-01 10:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 16:59 [PATCH] crypto: qat - Switch to new rsa_helper functions Salvatore Benedetto
2016-07-01 10:08 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701100850.GA13758@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=salvatore.benedetto@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox