From: Herbert Xu <herbert@gondor.apana.org.au>
To: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Cc: mpm@selenic.com, jslaby@suse.cz, peter@korsgaard.com,
Lee Jones <lee.jones@linaro.org>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH] hwrng: core - Allocate memory during module init
Date: Wed, 7 Sep 2016 21:16:56 +0800 [thread overview]
Message-ID: <20160907131656.GD17176@gondor.apana.org.au> (raw)
In-Reply-To: <CANc+2y6ywn-9E0Cv5io6=ZWRFW8Q+GTnubFH31p0y1-WQsGbYQ@mail.gmail.com>
On Wed, Sep 07, 2016 at 06:44:32PM +0530, PrasannaKumar Muralidharan wrote:
>
> Ah, yes! I can send a revised patch.
> Do you think allocating rng_buffer, rng_fillbuf in module init useful?
> If not there is no point in sending a new patch with fix.
Yes I think it makes sense. Those who want to save a few bytes
by keeping the RNGs as modules can always build core HWRNG as a
module too.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2016-09-07 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 8:29 [PATCH] hwrng: core - Allocate memory during module init PrasannaKumar Muralidharan
2016-09-07 12:53 ` Herbert Xu
2016-09-07 13:14 ` PrasannaKumar Muralidharan
2016-09-07 13:16 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907131656.GD17176@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=jslaby@suse.cz \
--cc=lee.jones@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=peter@korsgaard.com \
--cc=prasannatsmkumar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox