From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tero Kristo <t-kristo@ti.com>
Cc: lokeshvutla@ti.com, davem@davemloft.net,
linux-crypto@vger.kernel.org, tony@atomide.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Lokesh Vutla <a0131933@ti.com>
Subject: Re: [PATCHv3 06/11] crypto: omap-des: Fix support for unequal lengths
Date: Tue, 13 Sep 2016 17:35:06 +0800 [thread overview]
Message-ID: <20160913093506.GA30561@gondor.apana.org.au> (raw)
In-Reply-To: <1470306526-27219-7-git-send-email-t-kristo@ti.com>
On Thu, Aug 04, 2016 at 01:28:41PM +0300, Tero Kristo wrote:
> From: Lokesh Vutla <a0131933@ti.com>
>
> For cases where total length of an input SGs is not same as
> length of the input data for encryption, omap-des driver
> crashes. This happens in the case when IPsec is trying to use
> omap-des driver.
>
> To avoid this, we copy all the pages from the input SG list
> into a contiguous buffer and prepare a single element SG list
> for this buffer with length as the total bytes to crypt, which is
> similar thing that is done in case of unaligned lengths.
Ugh, that means copying every single packet, right?
So if it's just the SG list that's the problem, why don't you
copy that instead? That is, allocate a new SG list and set it
up so that there is no excess data.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-09-13 9:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 10:28 [PATCHv3 00/11] crypto: omap HW crypto fixes Tero Kristo
2016-08-04 10:28 ` [PATCHv3 01/11] crypto: omap-sham: avoid executing tasklet where not needed Tero Kristo
2016-08-04 10:28 ` [PATCHv3 02/11] crypto: omap-sham: add support for flushing the buffer Tero Kristo
2016-08-04 10:28 ` [PATCHv3 03/11] crypto: omap-sham: implement context export/import APIs Tero Kristo
2016-08-09 10:06 ` Herbert Xu
2016-08-29 14:11 ` Tero Kristo
2016-09-01 3:33 ` Herbert Xu
2016-09-01 6:12 ` Tero Kristo
2016-09-01 6:16 ` Herbert Xu
2016-09-01 6:56 ` Tero Kristo
2016-09-01 7:19 ` Herbert Xu
2016-09-01 7:28 ` Tero Kristo
2016-09-01 7:31 ` Herbert Xu
2016-09-01 7:46 ` Tero Kristo
2016-09-05 12:06 ` Tero Kristo
2016-09-07 13:29 ` Herbert Xu
2016-08-04 10:28 ` [PATCHv3 04/11] crypto: omap-sham: fix software fallback handling Tero Kristo
2016-08-04 10:28 ` [PATCHv3 05/11] crypto: omap-sham: fix SW fallback HMAC handling for omap2/omap3 Tero Kristo
2016-08-04 10:28 ` [PATCHv3 06/11] crypto: omap-des: Fix support for unequal lengths Tero Kristo
2016-09-13 9:35 ` Herbert Xu [this message]
2016-09-15 9:15 ` Tero Kristo
2016-08-04 10:28 ` [PATCHv3 07/11] crypto: omap-aes: use runtime_pm autosuspend for clock handling Tero Kristo
2016-08-04 10:28 ` [PATCHv3 08/11] crypto: omap-aes: Add support for multiple cores Tero Kristo
2016-08-04 10:28 ` [PATCHv3 09/11] crypto: omap-aes: Add fallback support Tero Kristo
2016-08-04 10:28 ` [PATCHv3 10/11] crypto: omap-aes: fix crypto engine initialization order Tero Kristo
2016-08-04 10:28 ` [PATCHv3 11/11] crypto: omap-des: " Tero Kristo
2016-09-13 12:38 ` [PATCHv3 00/11] crypto: omap HW crypto fixes Herbert Xu
2016-09-15 9:12 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913093506.GA30561@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=a0131933@ti.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox