From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [PATCH 0/6] crypto: arm64 - big endian fixes Date: Tue, 11 Oct 2016 10:12:47 +0800 Message-ID: <20161011021247.GA10976@gondor.apana.org.au> References: <1476034945-9186-1-git-send-email-ard.biesheuvel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "linux-crypto@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , Will Deacon To: Ard Biesheuvel Return-path: Received: from helcar.hengli.com.au ([209.40.204.226]:59969 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753010AbcJKCMz (ORCPT ); Mon, 10 Oct 2016 22:12:55 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Mon, Oct 10, 2016 at 12:26:00PM +0100, Ard Biesheuvel wrote: > > /* This piece of crap needs to disappear into per-type test hooks. */ > if (!((type ^ CRYPTO_ALG_TYPE_BLKCIPHER) & > CRYPTO_ALG_TYPE_BLKCIPHER_MASK) && !(type & CRYPTO_ALG_GENIV) && > ((alg->cra_flags & CRYPTO_ALG_TYPE_MASK) == > CRYPTO_ALG_TYPE_BLKCIPHER ? alg->cra_blkcipher.ivsize : > alg->cra_ablkcipher.ivsize)) > type |= CRYPTO_ALG_TESTED; > > This causes cbc(aes), ctr(aes) and xts(aes) to remain untested, unless > I add CRYPTO_ALG_GENIV to their cra_flags. Is this expected behavior? > What would be your recommended way to ensure these algos are covered > by the boottime tests? This is a leftover from the old blkcipher/ablkcipher interface. I've got a patch pending which will remove this if clause. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt