linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: hariprasad@chelsio.com
Cc: linux-crypto@vger.kernel.org
Subject: [bug report] chcr: Support for Chelsio's Crypto Hardware
Date: Wed, 12 Oct 2016 09:13:01 +0300	[thread overview]
Message-ID: <20161012061301.GL12841@mwanda> (raw)

Hello Hariprasad Shenai,

This is a semi-automatic email about new static checker warnings.

The patch 324429d74127: "chcr: Support for Chelsio's Crypto Hardware" 
from Aug 17, 2016, leads to the following Smatch complaint:

drivers/crypto/chelsio/chcr_algo.c:378 write_sg_data_page_desc()
	 error: we previously assumed 'sg' could be null (see line 376)

drivers/crypto/chelsio/chcr_algo.c
   375		while (count > 0) {
   376			if (sg && (!(sg->length)))
                            ^^
Check.

   377				break;
   378			spage = sg_page(sg);
                                ^^^^^^^^^^^
Unchecked dereference inside function.

   379			get_page(spage);
   380			page_len = min(sg->length, count);

regards,
dan carpenter

                 reply	other threads:[~2016-10-12  7:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161012061301.GL12841@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=hariprasad@chelsio.com \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).