linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [bug report] crypto: omap-sham - add support functions for sg based data handling
@ 2016-10-13  9:31 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-10-13  9:31 UTC (permalink / raw)
  To: t-kristo; +Cc: linux-crypto

Hello Tero Kristo,

This is a semi-automatic email about new static checker warnings.

The patch f19de1bc67a0: "crypto: omap-sham - add support functions 
for sg based data handling" from Sep 19, 2016, leads to the following 
Smatch complaint:

drivers/crypto/omap-sham.c:808 omap_sham_prepare_request()
	 warn: variable dereferenced before check 'req' (see line 801)

drivers/crypto/omap-sham.c
   800	{
   801		struct omap_sham_reqctx *rctx = ahash_request_ctx(req);
                                                                  ^^^
New dereference inside function.

   802		int bs;
   803		int ret;
   804		int nbytes;
   805		bool final = rctx->flags & BIT(FLAGS_FINUP);
   806		int xmit_len, hash_later;
   807	
   808		if (!req)
                    ^^^^
New check is too late.

   809			return 0;
   810	

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-10-13  9:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-13  9:31 [bug report] crypto: omap-sham - add support functions for sg based data handling Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).