From: Herbert Xu <herbert@gondor.apana.org.au>
To: Andy Lutomirski <luto@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Mackall <mpm@selenic.com>,
Rusty Russell <rusty@rustcorp.com.au>, Jens Axboe <axboe@fb.com>,
Matt Mullins <mmullins@mmlx.us>
Subject: Re: [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness()
Date: Wed, 19 Oct 2016 11:50:12 +0800 [thread overview]
Message-ID: <20161019035012.GA2192@gondor.apana.org.au> (raw)
In-Reply-To: <4169224b6858d1cf149f1a73f8a03603fa19076d.1476638125.git.luto@kernel.org>
On Mon, Oct 17, 2016 at 10:06:27AM -0700, Andy Lutomirski wrote:
> hw_random carefully avoids using a stack buffer except in
> add_early_randomness(). This causes a crash in virtio_rng if
> CONFIG_VMAP_STACK=y.
>
> Reported-by: Matt Mullins <mmullins@mmlx.us>
> Tested-by: Matt Mullins <mmullins@mmlx.us>
> Fixes: d3cc7996473a ("hwrng: fetch randomness only after device init")
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-10-19 3:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 17:06 [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness() Andy Lutomirski
2016-10-16 21:19 ` [PATCH " Matt Mullins
2016-10-17 17:17 ` [PATCH resend " Stephan Mueller
2016-10-17 17:30 ` Andy Lutomirski
2016-10-17 18:36 ` Stephan Mueller
2016-10-17 21:03 ` Andy Lutomirski
2016-10-17 21:14 ` Stephan Mueller
2016-10-19 3:50 ` Herbert Xu [this message]
2017-02-04 3:47 ` Yisheng Xie
2017-02-04 4:34 ` Matt Mullins
2017-02-04 10:32 ` Yisheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019035012.GA2192@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=axboe@fb.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mmullins@mmlx.us \
--cc=mpm@selenic.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox