From: Herbert Xu <herbert@gondor.apana.org.au>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH v9 1/8] crypto: add asynchronous compression api
Date: Fri, 21 Oct 2016 10:55:18 +0800 [thread overview]
Message-ID: <20161021025518.GA22979@gondor.apana.org.au> (raw)
In-Reply-To: <1475144342-1157-2-git-send-email-giovanni.cabiddu@intel.com>
On Thu, Sep 29, 2016 at 11:18:55AM +0100, Giovanni Cabiddu wrote:
>
> + if (nla_put(skb, CRYPTOCFGA_REPORT_COMPRESS,
> + sizeof(struct crypto_report_comp), &racomp))
> + goto nla_put_failure;
This bit doesn't compile for me. Please fix up and resubmit.
../crypto/crypto_user.c: In function ‘crypto_report_acomp’:
../crypto/crypto_user.c:117:29: error: storage size of ‘racomp’ isn’t known
../crypto/crypto_user.c:121:19: error: ‘CRYPTOCFGA_REPORT_ACOMPRESS’ undeclared (first use in this function)
../crypto/crypto_user.c:121:19: note: each undeclared identifier is reported only once for each function it appears in
../crypto/crypto_user.c:122:14: error: invalid application of ‘sizeof’ to incomplete type ‘struct crypto_report_acomp’
../crypto/crypto_user.c:117:29: warning: unused variable ‘racomp’ [-Wunused-variable]
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-10-21 2:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 10:18 [PATCH v9 0/8] crypto: asynchronous compression api Giovanni Cabiddu
2016-09-29 10:18 ` [PATCH v9 1/8] crypto: add " Giovanni Cabiddu
2016-10-21 2:55 ` Herbert Xu [this message]
2016-09-29 10:18 ` [PATCH v9 2/8] crypto: add driver-side scomp interface Giovanni Cabiddu
2016-09-29 10:18 ` [PATCH v9 3/8] crypto: acomp - add support for lzo via scomp Giovanni Cabiddu
2016-09-29 10:18 ` [PATCH v9 4/8] crypto: acomp - add support for lz4 " Giovanni Cabiddu
2016-09-29 10:18 ` [PATCH v9 5/8] crypto: acomp - add support for lz4hc " Giovanni Cabiddu
2016-09-29 10:19 ` [PATCH v9 6/8] crypto: acomp - add support for 842 " Giovanni Cabiddu
2016-09-29 10:19 ` [PATCH v9 7/8] crypto: acomp - add support for deflate " Giovanni Cabiddu
2016-09-29 10:19 ` [PATCH v9 8/8] crypto: acomp - update testmgr with support for acomp Giovanni Cabiddu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021025518.GA22979@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=giovanni.cabiddu@intel.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox