From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicholas Piggin Subject: [PATCH] crypto: vmx - rebuild generated asm when target changes Date: Sat, 26 Nov 2016 15:24:59 +1100 Message-ID: <20161126042459.1964-1-npiggin@gmail.com> Cc: Nicholas Piggin , "Leonidas S . Barbosa" , Paulo Flabiano Smorigo , linux-crypto@vger.kernel.org, Michael Ellerman , linuxppc-dev@lists.ozlabs.org To: Herbert Xu Return-path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:34268 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753053AbcKZEZT (ORCPT ); Fri, 25 Nov 2016 23:25:19 -0500 Received: by mail-pg0-f68.google.com with SMTP id e9so7095314pgc.1 for ; Fri, 25 Nov 2016 20:25:19 -0800 (PST) Sender: linux-crypto-owner@vger.kernel.org List-ID: Switching from big endian to little endian can fail to regenerate the crypto assembly properly. Switch to using standard form of kbuild dependency checking (i.e., use FORCE and if_changed). Signed-off-by: Nicholas Piggin --- drivers/crypto/vmx/Makefile | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/vmx/Makefile b/drivers/crypto/vmx/Makefile index b47da00..16ab2a0 100644 --- a/drivers/crypto/vmx/Makefile +++ b/drivers/crypto/vmx/Makefile @@ -1,6 +1,8 @@ obj-$(CONFIG_CRYPTO_DEV_VMX_ENCRYPT) += vmx-crypto.o vmx-crypto-objs := vmx.o aesp8-ppc.o ghashp8-ppc.o aes.o aes_cbc.o aes_ctr.o aes_xts.o ghash.o +targets += aesp8-ppc.S ghashp8-ppc.S + ifdef CONFIG_CPU_LITTLE_ENDIAN TARGET := linux-ppc64le else @@ -11,13 +13,13 @@ TARGET := linux-ppc64 endif endif -quiet_cmd_perl = PERL $@ +quiet_cmd_perl = PERL $@ cmd_perl = $(PERL) $(<) $(TARGET) > $(@) -$(src)/aesp8-ppc.S: $(src)/aesp8-ppc.pl - $(call cmd,perl) +$(src)/aesp8-ppc.S: $(src)/aesp8-ppc.pl FORCE + $(call if_changed,perl) -$(src)/ghashp8-ppc.S: $(src)/ghashp8-ppc.pl - $(call cmd,perl) +$(src)/ghashp8-ppc.S: $(src)/ghashp8-ppc.pl FORCE + $(call if_changed,perl) .PRECIOUS: $(obj)/aesp8-ppc.S $(obj)/ghashp8-ppc.S -- 2.10.2