From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] crypto: fix ifnullfree.cocci warnings Date: Tue, 29 Nov 2016 01:42:38 +0800 Message-ID: <20161128174238.GA56397@lkp-ib03.lkp.intel.com> References: <201611290136.N4sAw6FB%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, linux-crypto@vger.kernel.org To: Herbert Xu Return-path: Received: from mga03.intel.com ([134.134.136.65]:47763 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752236AbcK1RnB (ORCPT ); Mon, 28 Nov 2016 12:43:01 -0500 Content-Disposition: inline In-Reply-To: <201611290136.N4sAw6FB%fengguang.wu@intel.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: crypto/lrw.c:313:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Signed-off-by: Fengguang Wu --- lrw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/crypto/lrw.c +++ b/crypto/lrw.c @@ -309,8 +309,7 @@ static void exit_crypt(struct skcipher_r rctx->left = 0; - if (rctx->ext) - kfree(rctx->ext); + kfree(rctx->ext); } static int do_encrypt(struct skcipher_request *req, int err)