From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Horia Geantă" <horia.geanta@nxp.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, Dan Douglass <dan.douglass@nxp.com>
Subject: Re: [PATCH] crypto: caam - fix key pointer size warning
Date: Thu, 1 Dec 2016 20:53:58 +0800 [thread overview]
Message-ID: <20161201125358.GA2249@gondor.apana.org.au> (raw)
In-Reply-To: <1480407769-15336-1-git-send-email-horia.geanta@nxp.com>
On Tue, Nov 29, 2016 at 10:22:49AM +0200, Horia Geantă wrote:
> When building on 32-bit, compiler issues [-Wint-to-pointer-cast] warnings:
>
> drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_aead_null_encap':
> drivers/crypto/caam/caamalg_desc.c:67:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> append_key_as_imm(desc, (void *)adata->key, adata->keylen_pad,
> [...]
>
> Since in all these cases the u64 "key" member of alginfo struct holds
> a uintptr_t value, we can safely remove the warnings by explicitly casting
> to uinptr_t (before any other existing cast).
>
> Fixes: 8cea7b66b821 ("crypto: caam - refactor encryption descriptors generation")
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
Thanks for the patch. I think Arnd's version is cleaner though
so I'll take that instead.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2016-12-01 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 20:08 [cryptodev:master 109/113] drivers/crypto/caam/caamalg_desc.c:67:27: warning: cast to pointer from integer of different size kbuild test robot
2016-11-29 8:22 ` [PATCH] crypto: caam - fix key pointer size warning Horia Geantă
2016-12-01 12:53 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201125358.GA2249@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dan.douglass@nxp.com \
--cc=davem@davemloft.net \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox